webrtc/modules/desktop_capture/desktop_and_cursor_composer.h - Issue 1988783003: Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/desktop_and_cursor_composer.h

Issue 1988783003: Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/desktop_capture/cropped_desktop_frame.cc ('K') | « webrtc/modules/desktop_capture/cropping_window_capturer.cc ('k') | webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc » ('j') | webrtc/modules/desktop_capture/desktop_capturer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/desktop_capture/desktop_and_cursor_composer.h

diff --git a/webrtc/modules/desktop_capture/desktop_and_cursor_composer.h b/webrtc/modules/desktop_capture/desktop_and_cursor_composer.h

index dcbe6129e6513468eb9cf8677f0d38d3ec08ad57..55bc2eddf88f47f7d2583f41ca9efc08b94c6d1f 100644

--- a/webrtc/modules/desktop_capture/desktop_and_cursor_composer.h

+++ b/webrtc/modules/desktop_capture/desktop_and_cursor_composer.h

@@ -42,7 +42,7 @@ class DesktopAndCursorComposer : public DesktopCapturer,

private:

// DesktopCapturer::Callback interface.

- void OnCaptureCompleted(DesktopFrame* frame) override;

+ void OnCaptureCompleted(std::unique_ptr<DesktopFrame> frame) override;

// MouseCursorMonitor::Callback interface.

void OnMouseCursor(MouseCursor* cursor) override;