webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h - Issue 1988783003: Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

Issue 1988783003: Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/desktop_capture/shared_desktop_frame.cc ('k') | webrtc/modules/desktop_capture/win/screen_capturer_win_directx.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

diff --git a/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h b/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

index 3d33ea6b8e2d4f342767dd34eb3777232667bb89..d477991e7370be79cc17fd1505c67e3c2c51ab8d 100644

--- a/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

+++ b/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

@@ -82,9 +82,7 @@ class ScreenCapturerWinDirectx : public ScreenCapturer {

const char* stage);

// Processes one frame received from AcquireNextFrame function, returns a

- // nullptr if anything wrong, and Capture function will call

- // callback_->OnCaptureCompleted(nullptr), otherwise

- // callback_->OnCaptureCompleted(frame) will be called.

+ // nullptr if anything wrong.

std::unique_ptr<DesktopFrame> ProcessFrame(

const DXGI_OUTDUPL_FRAME_INFO& frame_info,

IDXGIResource* resource);