Fix UBSan errors (left shift of negative value)

Fix UBSan errors (left shift of negative value)

BUG=chromium:603501
Committed: https://crrev.com/9b2228fdfc63ad0280de4f12eb9f12bc38d291f4
Cr-Commit-Position: refs/heads/master@{#12775}

[kwiberg-webrtc, 2016-05-17 12:06:32]

kwiberg@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[tlegrand, 2016-05-17 12:24:32]

tlegrand@google.com changed reviewers:
+ tlegrand@google.com

[tlegrand, 2016-05-17 12:24:32]

LGTM

https://codereview.webrtc.org/1988723002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c (right):

https://codereview.webrtc.org/1988723002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c:68: low =
(int16_t)((fPtr[-1] & 0xffff) >> 1);
This is so much nicer!

[tlegrand-webrtc, 2016-05-17 12:25:24]

Arrggg! Wrong account. LGTM

[tlegrand-webrtc, 2016-05-17 12:25:37]

Description was changed from

==========
Fix UBSan errors (left shift of negative value)

BUG=chromium:603501
==========

to

==========
Fix UBSan errors (left shift of negative value)

BUG=chromium:603501
==========

[tlegrand-webrtc, 2016-05-17 12:25:38]

tina.legrand@webrtc.org changed reviewers:
- tlegrand@google.com

[kwiberg-webrtc, 2016-05-17 12:28:43]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-05-17 12:28:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988723002/1

[kwiberg-webrtc, 2016-05-17 12:32:29]

https://codereview.webrtc.org/1988723002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c (right):

https://codereview.webrtc.org/1988723002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/ilbc/get_lsp_poly.c:68: low =
(int16_t)((fPtr[-1] & 0xffff) >> 1);
On 2016/05/17 12:24:32, tlegrand wrote:
> This is so much nicer!

I've found the "x_low = x - x_high << 16" pattern in other places too. It
appears someone was in the habit of writing it that way...

Luckily, the compiler is smart enough to generate the same code regardless, so
this is just a source code improvement.

[commit-bot: I haz the power, 2016-05-17 13:40:45]

Description was changed from

==========
Fix UBSan errors (left shift of negative value)

BUG=chromium:603501
==========

to

==========
Fix UBSan errors (left shift of negative value)

BUG=chromium:603501
==========

[commit-bot: I haz the power, 2016-05-17 13:40:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 13:40:57]

Description was changed from

==========
Fix UBSan errors (left shift of negative value)

BUG=chromium:603501
==========

to

==========
Fix UBSan errors (left shift of negative value)

BUG=chromium:603501

Committed: https://crrev.com/9b2228fdfc63ad0280de4f12eb9f12bc38d291f4
Cr-Commit-Position: refs/heads/master@{#12775}
==========

[commit-bot: I haz the power, 2016-05-17 13:40:57]

Patchset 1 (id:??) landed as
https://crrev.com/9b2228fdfc63ad0280de4f12eb9f12bc38d291f4
Cr-Commit-Position: refs/heads/master@{#12775}