webrtc/modules/video_coding/packet.h - Issue 1988653002: PacketBuffer now can save how many times a packet has been nacked.

Side by Side Diff: webrtc/modules/video_coding/packet.h

Issue 1988653002: PacketBuffer now can save how many times a packet has been nacked. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: combined_size to frame_size Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 21 matching lines...) Expand all Loading...
32 void Reset();	32 void Reset();

33	33

34 uint8_t payloadType;	34 uint8_t payloadType;

35 uint32_t timestamp;	35 uint32_t timestamp;

36 // NTP time of the capture time in local timebase in milliseconds.	36 // NTP time of the capture time in local timebase in milliseconds.

37 int64_t ntp_time_ms_;	37 int64_t ntp_time_ms_;

38 uint16_t seqNum;	38 uint16_t seqNum;

39 const uint8_t* dataPtr;	39 const uint8_t* dataPtr;

40 size_t sizeBytes;	40 size_t sizeBytes;

41 bool markerBit;	41 bool markerBit;

	42 int timesNacked;
	stefan-webrtc 2016/05/23 13:01:25 Could you align these members so that they are fol Could you align these members so that they are following a single style, preferably in a follow-up? I'm thinking about line 37. Preferably all would be: int times_nacked; etc. philipel 2016/05/23 13:34:18 You mean change the format of the variable names? Show quoted text On 2016/05/23 13:01:25, stefan-webrtc (holmer) wrote: > Could you align these members so that they are following a single style, > preferably in a follow-up? I'm thinking about line 37. Preferably all would be: > int times_nacked; > etc. You mean change the format of the variable names? Sure, I can do that in some follow-up CL...
42	43

43 FrameType frameType;	44 FrameType frameType;

44 VideoCodecType codec;	45 VideoCodecType codec;

45	46

46 bool isFirstPacket; // Is this first packet in a frame.	47 bool isFirstPacket; // Is this first packet in a frame.

47 VCMNaluCompleteness completeNALU; // Default is kNaluIncomplete.	48 VCMNaluCompleteness completeNALU; // Default is kNaluIncomplete.

48 bool insertStartCode; // True if a start code should be inserted before this	49 bool insertStartCode; // True if a start code should be inserted before this

49 // packet.	50 // packet.

50 int width;	51 int width;

51 int height;	52 int height;

52 RTPVideoHeader codecSpecificHeader;	53 RTPVideoHeader codecSpecificHeader;

53	54

	55
	stefan-webrtc 2016/05/23 13:01:24 Remove one empty line Remove one empty line philipel 2016/05/23 13:34:18 Done. Show quoted text On 2016/05/23 13:01:24, stefan-webrtc (holmer) wrote: > Remove one empty line Done.
54 protected:	56 protected:

55 void CopyCodecSpecifics(const RTPVideoHeader& videoHeader);	57 void CopyCodecSpecifics(const RTPVideoHeader& videoHeader);

56 };	58 };

57	59

58 } // namespace webrtc	60 } // namespace webrtc

59 #endif // WEBRTC_MODULES_VIDEO_CODING_PACKET_H_	61 #endif // WEBRTC_MODULES_VIDEO_CODING_PACKET_H_

OLD	NEW