PacketBuffer now can save how many times a packet has been nacked.

webrtc/modules/video_coding/packet.cc

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/video_coding/packet.h"
 
 #include <assert.h>
 
 #include "webrtc/modules/include/module_common_types.h"
 
 namespace webrtc {
 
 VCMPacket::VCMPacket()
     : payloadType(0),
       timestamp(0),
       ntp_time_ms_(0),
       seqNum(0),
       dataPtr(NULL),
       sizeBytes(0),
       markerBit(false),
+      timesNacked(-1),

[terelius, 2016/05/23 11:49:55]

Why does a newly constructed (that has not been nacked yet) have timesNacked =
-1? Wouldn't zero be more natural?

[philipel, 2016/05/23 13:34:17]

-1 mean we don't know, so 0 can mean 0.

       frameType(kEmptyFrame),
       codec(kVideoCodecUnknown),
       isFirstPacket(false),
       completeNALU(kNaluUnset),
       insertStartCode(false),
       width(0),
       height(0),
       codecSpecificHeader() {}
 
 VCMPacket::VCMPacket(const uint8_t* ptr,
                      const size_t size,
                      const WebRtcRTPHeader& rtpHeader)
     : payloadType(rtpHeader.header.payloadType),
       timestamp(rtpHeader.header.timestamp),
       ntp_time_ms_(rtpHeader.ntp_time_ms),
       seqNum(rtpHeader.header.sequenceNumber),
       dataPtr(ptr),
       sizeBytes(size),
       markerBit(rtpHeader.header.markerBit),
+      timesNacked(-1),
 
       frameType(rtpHeader.frameType),
       codec(kVideoCodecUnknown),
       isFirstPacket(rtpHeader.type.Video.isFirstPacket),
       completeNALU(kNaluComplete),
       insertStartCode(false),
       width(rtpHeader.type.Video.width),
       height(rtpHeader.type.Video.height),
       codecSpecificHeader(rtpHeader.type.Video) {
   CopyCodecSpecifics(rtpHeader.type.Video);
 }
 
 VCMPacket::VCMPacket(const uint8_t* ptr,
                      size_t size,
                      uint16_t seq,
                      uint32_t ts,
                      bool mBit)
     : payloadType(0),
       timestamp(ts),
       ntp_time_ms_(0),
       seqNum(seq),
       dataPtr(ptr),
       sizeBytes(size),
       markerBit(mBit),
+      timesNacked(-1),
 
       frameType(kVideoFrameDelta),
       codec(kVideoCodecUnknown),
       isFirstPacket(false),
       completeNALU(kNaluComplete),
       insertStartCode(false),
       width(0),
       height(0),
       codecSpecificHeader() {}
 
 void VCMPacket::Reset() {
   payloadType = 0;
   timestamp = 0;
   ntp_time_ms_ = 0;
   seqNum = 0;
   dataPtr = NULL;
   sizeBytes = 0;
   markerBit = false;
+  timesNacked = -1;
   frameType = kEmptyFrame;
   codec = kVideoCodecUnknown;
   isFirstPacket = false;
   completeNALU = kNaluUnset;
   insertStartCode = false;
   width = 0;
   height = 0;
   memset(&codecSpecificHeader, 0, sizeof(RTPVideoHeader));
 }
 
@@ skipping 46 matching lines @@
       codec = kVideoCodecH264;
       return;
     case kRtpVideoGeneric:
     case kRtpVideoNone:
       codec = kVideoCodecUnknown;
       return;
   }
 }
 
 }  // namespace webrtc