Reimplement PooledI420Buffer, without an extra indirection.

webrtc/base/refcount.h

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 89 matching lines @@
   }
 
   virtual int Release() const {
     int count = AtomicOps::Decrement(&ref_count_);
     if (!count) {
       delete this;
     }
     return count;
   }
 
+  // This call returns the reference count, and performs the memory
+  // barrier needed for the owning thread to act on the object, in
+  // case the value of the reference count implies exclusive access to
+  // the object.
+  virtual int GetRefCount() const {

[pbos-webrtc, 2016/05/20 13:32:21]

I think this method should also be going away, so pref adding a TODO to remove
it here?

[nisse-webrtc, 2016/05/23 07:35:06]

I can add a TODO like "Currently used only for I420PooledBuffer::IsMutable,
consider deleting when IsMutable is deleted." But I think it might be useful for
debugging, I remember I've been wanting to call it from gdb sometime.

+    return AtomicOps::AcquireLoad(&ref_count_);
+  }
   // Return whether the reference count is one. If the reference count is used
   // in the conventional way, a reference count of 1 implies that the current
   // thread owns the reference and no other thread shares it. This call
   // performs the test for a reference count of one, and performs the memory
   // barrier needed for the owning thread to act on the object, knowing that it
   // has exclusive access to the object.
-  virtual bool HasOneRef() const {
-    return AtomicOps::AcquireLoad(&ref_count_) == 1;
-  }
+  virtual bool HasOneRef() const { return GetRefCount() == 1; }
 
  protected:
   virtual ~RefCountedObject() {
   }
 
   mutable volatile int ref_count_;
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_REFCOUNT_H_