Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1988113003: Fix UBSan errors (left shift of negative value) (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix UBSan errors (left shift of negative value) BUG=chromium:604803 Committed: https://crrev.com/3fc8e8dde365392da56724a33c2b8a05f5da75d2 Cr-Commit-Position: refs/heads/master@{#12826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M webrtc/modules/audio_coding/codecs/ilbc/do_plc.c View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-05-19 13:19:34 UTC) #2
tlegrand-webrtc
lgtm
4 years, 7 months ago (2016-05-20 10:40:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988113003/1
4 years, 7 months ago (2016-05-20 11:35:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 11:40:35 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 11:40:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3fc8e8dde365392da56724a33c2b8a05f5da75d2
Cr-Commit-Position: refs/heads/master@{#12826}

Powered by Google App Engine
This is Rietveld 408576698