Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java

Issue 1988043002: Call java SurfaceTextureHelper.dispose from the corresponding C++ destructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Indentation tweak. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/java/jni/surfacetexturehelper_jni.cc ('k') | webrtc/base/java/src/org/webrtc/ThreadUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java
diff --git a/webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java b/webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java
index 6a3e7107691287a821dc4090317a9135a3190e15..739d3bd258c4e06a5b8695988f3ca81655c51ac9 100644
--- a/webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java
+++ b/webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java
@@ -547,10 +547,10 @@ public class MediaCodecVideoDecoder {
}
public void release() {
- // SurfaceTextureHelper.dispose() will block until any onTextureFrameAvailable() in
- // progress is done. Therefore, the call to dispose() must be outside any synchronized
+ // SurfaceTextureHelper.stopListening() will block until any onTextureFrameAvailable() in
+ // progress is done. Therefore, the call must be outside any synchronized
// statement that is also used in the onTextureFrameAvailable() above to avoid deadlocks.
- surfaceTextureHelper.dispose();
+ surfaceTextureHelper.stopListening();
synchronized (newFrameLock) {
if (renderedBuffer != null) {
surfaceTextureHelper.returnTextureFrame();
« no previous file with comments | « webrtc/api/java/jni/surfacetexturehelper_jni.cc ('k') | webrtc/base/java/src/org/webrtc/ThreadUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698