webrtc/api/java/jni/androidvideocapturer_jni.cc - Issue 1988043002: Call java SurfaceTextureHelper.dispose from the corresponding C++ destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/jni/androidvideocapturer_jni.cc

Issue 1988043002: Call java SurfaceTextureHelper.dispose from the corresponding C++ destructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Indentation tweak. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/api/java/android/org/webrtc/SurfaceTextureHelper.java ('k') | webrtc/api/java/jni/surfacetexturehelper_jni.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/api/java/jni/androidvideocapturer_jni.cc

diff --git a/webrtc/api/java/jni/androidvideocapturer_jni.cc b/webrtc/api/java/jni/androidvideocapturer_jni.cc

index 5b4a92c6e872e84f06229af8dbf296044cd26d0d..7a5630f0d406e94f4821162e04b32495c43c2532 100644

--- a/webrtc/api/java/jni/androidvideocapturer_jni.cc

+++ b/webrtc/api/java/jni/androidvideocapturer_jni.cc

@@ -52,13 +52,6 @@ AndroidVideoCapturerJni::~AndroidVideoCapturerJni() {

*j_video_capturer_,

GetMethodID(jni(), *j_video_capturer_class_, "dispose", "()V"));

CHECK_EXCEPTION(jni()) << "error during VideoCapturer.dispose()";

- if (surface_texture_helper_) {

- jni()->CallVoidMethod(

- surface_texture_helper_->GetJavaSurfaceTextureHelper(),

- GetMethodID(jni(), FindClass(jni(), "org/webrtc/SurfaceTextureHelper"),

- "dispose", "()V"));

- }

- CHECK_EXCEPTION(jni()) << "error during SurfaceTextureHelper.dispose()";

}

void AndroidVideoCapturerJni::Start(int width, int height, int framerate,

« no previous file with comments | « webrtc/api/java/android/org/webrtc/SurfaceTextureHelper.java ('k') | webrtc/api/java/jni/surfacetexturehelper_jni.h » ('j') | no next file with comments »