Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1988003002: Fix Info.plist path in build_ios_libs.sh (Closed)

Created:
4 years, 7 months ago by tkchin_webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Info.plist path in build_ios_libs.sh NOTRY=True BUG= Committed: https://crrev.com/3c5a294b60874b9855d10e343ca0a00bc21c7b61 Cr-Commit-Position: refs/heads/master@{#12784}

Patch Set 1 #

Patch Set 2 : Add missing header to silence umbrella header warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/build/ios/build_ios_libs.sh View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkchin_webrtc
I don't actually know if this ever worked on the bot heh. It worked fine ...
4 years, 7 months ago (2016-05-18 05:40:13 UTC) #3
kjellander_webrtc
On 2016/05/18 05:40:13, tkchin_webrtc wrote: > I don't actually know if this ever worked on ...
4 years, 7 months ago (2016-05-18 05:50:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988003002/20001
4 years, 7 months ago (2016-05-18 06:02:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 06:08:34 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3c5a294b60874b9855d10e343ca0a00bc21c7b61 Cr-Commit-Position: refs/heads/master@{#12784}
4 years, 7 months ago (2016-05-18 06:08:40 UTC) #13
kjellander_webrtc
4 years, 7 months ago (2016-05-18 07:18:50 UTC) #14
Message was sent while issue was closed.
On 2016/05/18 06:08:40, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/3c5a294b60874b9855d10e343ca0a00bc21c7b61
> Cr-Commit-Position: refs/heads/master@{#12784}

The bot is now green:
https://build.chromium.org/p/client.webrtc.fyi/builders/iOS%20API%20Framework...

Yay!

Powered by Google App Engine
This is Rietveld 408576698