android: Don't do a thread jump for incoming frames.

webrtc/api/androidvideocapturer.cc

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 162 matching lines @@
   if (new_state == current_state_)
     return;
   current_state_ = new_state;
   SetCaptureState(new_state);
 }
 
 void AndroidVideoCapturer::OnIncomingFrame(
     const rtc::scoped_refptr<webrtc::VideoFrameBuffer>& buffer,
     int rotation,
     int64_t time_stamp) {
-  RTC_CHECK(thread_checker_.CalledOnValidThread());
+  // NOTE: The frame_factory hack isn't thread safe. It works because

[pbos-webrtc, 2016/05/20 13:22:47]

Should there be a TODO here?

[nisse-webrtc, 2016/05/20 13:32:26]

I have a different cl which deletes that frame factory. And we all know that, so
I don't think a TODO comment is needed. I really hope to land that deletion next
week.

+  // all calls to this method are from the same Java thread. In
+  // addition, calls are currently syncronized on the caller's
+  // AndroidVideoCapturerJni:capturer_lock_.
   frame_factory_->UpdateCapturedFrame(buffer, rotation, time_stamp);
   SignalFrameCaptured(this, frame_factory_->GetCapturedFrame());
   frame_factory_->ClearCapturedFrame();
 }
 
 void AndroidVideoCapturer::OnOutputFormatRequest(
     int width, int height, int fps) {
   RTC_CHECK(thread_checker_.CalledOnValidThread());
   cricket::VideoFormat format(width, height,
                               cricket::VideoFormat::FpsToInterval(fps), 0);
   video_adapter()->OnOutputFormatRequest(format);
 }
 
 bool AndroidVideoCapturer::GetBestCaptureFormat(
     const cricket::VideoFormat& desired,
     cricket::VideoFormat* best_format) {
   // Delegate this choice to VideoCapturer.startCapture().
   *best_format = desired;
   return true;
 }
 
 }  // namespace webrtc