Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1987143003:
Enable muted state by default in VoE (Closed)
|
Created:
4 years, 7 months ago by hlundin-webrtc Modified:
4 years, 7 months ago Reviewers:
tlegrand-webrtc CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun Base URL:
https://chromium.googlesource.com/external/webrtc.git@muted-connect-voe-mix Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEnable muted state by default in VoE
This change turns muted state on by default in VoiceEngine, but not
for NetEq or AudioCodingModule when used stand-alone.
The expected effect is that voice channels that have not received any
packets for some time should reduce their CPU usage. This should have
a noticeable effect on endpoints with many incoming streams, but where
only a few have packets incoming at any given time (i.e., where an
intermediate server filters out the majority of the streams).
BUG=webrtc:5606
NOTRY=True
Committed: https://crrev.com/a89ab965f214288523205afc445e17c38437856d
Cr-Commit-Position: refs/heads/master@{#12797}
Patch Set 1 #Patch Set 2 : Fixing an error with file playing #
Depends on Patchset: Messages
Total messages: 19 (10 generated)
henrik.lundin@webrtc.org changed reviewers: + tina.legrand@webrtc.org
Tina, PTAL at this CL. Thanks!
lgtm
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987143003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/11374)
Fixing an error with file playing
The CQ bit was checked by henrik.lundin@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tina.legrand@webrtc.org Link to the patchset: https://codereview.webrtc.org/1987143003/#ps20001 (title: "Fixing an error with file playing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987143003/20001
The CQ bit was unchecked by henrik.lundin@webrtc.org
Description was changed from ========== Enable muted state by default in VoE This change turns muted state on by default in VoiceEngine, but not for NetEq or AudioCodingModule when used stand-alone. The expected effect is that voice channels that have not received any packets for some time should reduce their CPU usage. This should have a noticeable effect on endpoints with many incoming streams, but where only a few have packets incoming at any given time (i.e., where an intermediate server filters out the majority of the streams). BUG=webrtc:5606 ========== to ========== Enable muted state by default in VoE This change turns muted state on by default in VoiceEngine, but not for NetEq or AudioCodingModule when used stand-alone. The expected effect is that voice channels that have not received any packets for some time should reduce their CPU usage. This should have a noticeable effect on endpoints with many incoming streams, but where only a few have packets incoming at any given time (i.e., where an intermediate server filters out the majority of the streams). BUG=webrtc:5606 NOTRY=True ==========
The CQ bit was checked by henrik.lundin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987143003/20001
Message was sent while issue was closed.
Description was changed from ========== Enable muted state by default in VoE This change turns muted state on by default in VoiceEngine, but not for NetEq or AudioCodingModule when used stand-alone. The expected effect is that voice channels that have not received any packets for some time should reduce their CPU usage. This should have a noticeable effect on endpoints with many incoming streams, but where only a few have packets incoming at any given time (i.e., where an intermediate server filters out the majority of the streams). BUG=webrtc:5606 NOTRY=True ========== to ========== Enable muted state by default in VoE This change turns muted state on by default in VoiceEngine, but not for NetEq or AudioCodingModule when used stand-alone. The expected effect is that voice channels that have not received any packets for some time should reduce their CPU usage. This should have a noticeable effect on endpoints with many incoming streams, but where only a few have packets incoming at any given time (i.e., where an intermediate server filters out the majority of the streams). BUG=webrtc:5606 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable muted state by default in VoE This change turns muted state on by default in VoiceEngine, but not for NetEq or AudioCodingModule when used stand-alone. The expected effect is that voice channels that have not received any packets for some time should reduce their CPU usage. This should have a noticeable effect on endpoints with many incoming streams, but where only a few have packets incoming at any given time (i.e., where an intermediate server filters out the majority of the streams). BUG=webrtc:5606 NOTRY=True ========== to ========== Enable muted state by default in VoE This change turns muted state on by default in VoiceEngine, but not for NetEq or AudioCodingModule when used stand-alone. The expected effect is that voice channels that have not received any packets for some time should reduce their CPU usage. This should have a noticeable effect on endpoints with many incoming streams, but where only a few have packets incoming at any given time (i.e., where an intermediate server filters out the majority of the streams). BUG=webrtc:5606 NOTRY=True Committed: https://crrev.com/a89ab965f214288523205afc445e17c38437856d Cr-Commit-Position: refs/heads/master@{#12797} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a89ab965f214288523205afc445e17c38437856d Cr-Commit-Position: refs/heads/master@{#12797} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
