Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1987093002: Only use PortAllocator on the network thread. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only use PortAllocator on the network thread. A previous CL started only using it on the worker thread, but it was written before the network thread was introduced. Committed: https://crrev.com/91dd567feafdf832e8d0a47abec01def869d4f2b Cr-Commit-Position: refs/heads/master@{#12802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M webrtc/api/peerconnection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/peerconnection.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-18 00:25:57 UTC) #2
pthatcher1
lgtm
4 years, 7 months ago (2016-05-18 00:27:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987093002/1
4 years, 7 months ago (2016-05-18 21:38:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 23:55:35 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 23:55:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91dd567feafdf832e8d0a47abec01def869d4f2b
Cr-Commit-Position: refs/heads/master@{#12802}

Powered by Google App Engine
This is Rietveld 408576698