Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1986963002: Remove DesktopFrame::shape(). (Closed)

Created:
4 years, 7 months ago by Sergey Ulanov
Modified:
4 years, 7 months ago
Reviewers:
Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove DesktopFrame::shape(). Frame shape is no longer used and can be removed. R=jamiewalch@chromium.org Committed: https://crrev.com/837dde9f1d2851129a346c50e260962cd656a8db Cr-Commit-Position: refs/heads/master@{#12783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M webrtc/modules/desktop_capture/desktop_frame.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sergey Ulanov
4 years, 7 months ago (2016-05-17 21:27:29 UTC) #2
Jamie
lgtm
4 years, 7 months ago (2016-05-17 21:37:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986963002/1
4 years, 7 months ago (2016-05-17 22:49:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-18 00:50:04 UTC) #7
Sergey Ulanov
4 years, 7 months ago (2016-05-18 05:03:54 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
837dde9f1d2851129a346c50e260962cd656a8db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698