Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1986753002: Revert of CQ: Disable win_x64_clang_dbg trybot (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of CQ: Disable win_x64_clang_dbg trybot (patchset #1 id:1 of https://codereview.webrtc.org/1896003004/ ) Reason for revert: With https://bugs.chromium.org/p/chromium/issues/detail?id=595702 being fixed 2 weeks ago and no new errors being reported. I'm attempting to re-enable this again. I ran a couple of trial tryjobs for our win_x64_clang_dbg trybot and it seems to compile fine. Original issue's description: > Reland of CQ: Disable win_x64_clang_dbg trybot (patchset #1 id:1 of https://codereview.webrtc.org/1897743002/ ) > > Reason for revert: > We got a new error on this again, so I'm removing this trybot from the CQ again: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/builds/2335/steps/compile/logs/stdio > > Original issue's description: > > Revert of CQ: Disable win_x64_clang_dbg trybot (patchset #1 id:1 of https://codereview.webrtc.org/1850113002/ ) > > > > Reason for revert: > > I think the bug has been making enough progress for us to turn this back on (Chrome turned on their trybot). > > I fired of builds and now have 6 green ones in a row. > > > > Original issue's description: > > > CQ: Disable win_x64_clang_dbg trybot > > > > > > Needed to unblock rolling chromium_revision in WebRTC DEPS. > > > > > > BUG=chromium:595702 > > > TBR=phoglund@webrtc.org > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/053fe8c6b14cb81880e37f9af3ea4fbde99e45fb > > > > TBR=phoglund@webrtc.org > > NOTRY=True > > BUG=chromium:595702 > > > > Committed: https://crrev.com/079ddd1507906bc030539fc33036dd5f6a9bbae0 > > Cr-Commit-Position: refs/heads/master@{#12399} > > TBR=phoglund@webrtc.org > NOTRY=True > BUG=chromium:595702 > > Committed: https://crrev.com/37286d141956d47c2b019dfee8bb48473809c1ef > Cr-Commit-Position: refs/heads/master@{#12421} TBR=phoglund@webrtc.org NOTRY=True BUG=chromium:595702 Committed: https://crrev.com/c5614798414aa72f8232fd14947f3c0bc35fe69a Cr-Commit-Position: refs/heads/master@{#12766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
Created Revert of CQ: Disable win_x64_clang_dbg trybot
4 years, 7 months ago (2016-05-17 08:00:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986753002/1
4 years, 7 months ago (2016-05-17 08:00:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 08:06:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c5614798414aa72f8232fd14947f3c0bc35fe69a Cr-Commit-Position: refs/heads/master@{#12766}
4 years, 7 months ago (2016-05-17 08:06:47 UTC) #8
phoglund
4 years, 7 months ago (2016-05-17 10:35:08 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698