Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1986073004: Add ice_candidate_pool_size to Obj-C and Java RTCConfiguration. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
AlexG, tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add ice_candidate_pool_size to Obj-C and Java RTCConfiguration. Committed: https://crrev.com/be0c96fd00d2fae1f461eb79b4ffbd6ff17428d5 Cr-Commit-Position: refs/heads/master@{#12801}

Patch Set 1 #

Patch Set 2 : Stylistic change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M webrtc/api/java/jni/peerconnection_jni.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/PeerConnection.java View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm View 4 chunks +6 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Taylor Brandstetter
You guys know the drill. :) glaznev@: Please review Java/JNI changes. tkchin@: Please review Obj-C ...
4 years, 7 months ago (2016-05-17 20:29:31 UTC) #2
AlexG
lgtm
4 years, 7 months ago (2016-05-17 21:32:57 UTC) #3
tkchin_webrtc
lgtm
4 years, 7 months ago (2016-05-18 05:18:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986073004/20001
4 years, 7 months ago (2016-05-18 21:38:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 23:20:19 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 23:20:27 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/be0c96fd00d2fae1f461eb79b4ffbd6ff17428d5
Cr-Commit-Position: refs/heads/master@{#12801}

Powered by Google App Engine
This is Rietveld 408576698