webrtc/modules/audio_coding/test/iSACTest.cc - Issue 1985743002: Propagate muted parameter to VoE::Channel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/test/iSACTest.cc

Issue 1985743002: Propagate muted parameter to VoE::Channel (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Resurrect the PlayoutData10Ms(int, AudioFrame*) method Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/test/iSACTest.cc

diff --git a/webrtc/modules/audio_coding/test/iSACTest.cc b/webrtc/modules/audio_coding/test/iSACTest.cc

index abc84b207323d288ff3c8b788c27366c3e45d9e7..f06833c2d909fc1d6a0216d3a941e7ab9286e39b 100644

--- a/webrtc/modules/audio_coding/test/iSACTest.cc

+++ b/webrtc/modules/audio_coding/test/iSACTest.cc

@@ -198,9 +198,12 @@ void ISACTest::Run10ms() {

EXPECT_GT(_inFileA.Read10MsData(audioFrame), 0);

EXPECT_GE(_acmA->Add10MsData(audioFrame), 0);

EXPECT_GE(_acmB->Add10MsData(audioFrame), 0);

- EXPECT_EQ(0, _acmA->PlayoutData10Ms(32000, &audioFrame));

+ bool muted;

+ EXPECT_EQ(0, _acmA->PlayoutData10Ms(32000, &audioFrame, &muted));

+ ASSERT_FALSE(muted);

_outFileA.Write10MsData(audioFrame);

- EXPECT_EQ(0, _acmB->PlayoutData10Ms(32000, &audioFrame));

+ EXPECT_EQ(0, _acmB->PlayoutData10Ms(32000, &audioFrame, &muted));

+ ASSERT_FALSE(muted);

_outFileB.Write10MsData(audioFrame);

}