Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: webrtc/voice_engine/channel.cc

Issue 1985743002: Propagate muted parameter to VoE::Channel (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/channel.cc
diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc
index 37b02702dc1539bb8a5f479b4ab14ba8a45ba9d8..7065d89fb92d7acac312364cdbd118e2c988be09 100644
--- a/webrtc/voice_engine/channel.cc
+++ b/webrtc/voice_engine/channel.cc
@@ -483,8 +483,9 @@ int32_t Channel::GetAudioFrame(int32_t id, AudioFrame* audioFrame) {
event_log_->LogAudioPlayout(ssrc);
}
// Get 10ms raw PCM data from the ACM (mixer limits output frequency)
- if (audio_coding_->PlayoutData10Ms(audioFrame->sample_rate_hz_, audioFrame) ==
- -1) {
+ bool muted;
+ if (audio_coding_->PlayoutData10Ms(audioFrame->sample_rate_hz_, audioFrame,
+ &muted) == -1) {
WEBRTC_TRACE(kTraceError, kTraceVoice, VoEId(_instanceId, _channelId),
"Channel::GetAudioFrame() PlayoutData10Ms() failed!");
// In all likelihood, the audio in this frame is garbage. We return an
@@ -493,6 +494,7 @@ int32_t Channel::GetAudioFrame(int32_t id, AudioFrame* audioFrame) {
// irrelevant.
return -1;
}
+ RTC_DCHECK(!muted);
if (_RxVadDetection) {
UpdateRxVadDetection(*audioFrame);
@@ -811,6 +813,7 @@ Channel::Channel(int32_t channelId,
}
acm_config.neteq_config.enable_fast_accelerate =
config.Get<NetEqFastAccelerate>().enabled;
+ RTC_DCHECK(!acm_config.neteq_config.enable_muted_state);
minyue-webrtc 2016/05/17 02:20:57 why not setting it to false then?
hlundin-webrtc 2016/05/17 07:18:44 Done.
audio_coding_.reset(AudioCodingModule::Create(acm_config));
_outputAudioLevel.Clear();
« webrtc/modules/utility/source/coder.cc ('K') | « webrtc/modules/utility/source/coder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698