Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1985693002: Make the FakeWebRtcVideoCaptureModule class initialize frame data. (Closed)

Created:
4 years, 7 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make the FakeWebRtcVideoCaptureModule class initialize frame data. Needed to avoid DrMemory warnings, if the frame is passed to libyuv AVX assembly functions. BUG=libyuv:377 Committed: https://crrev.com/744494f451e98680895f62e85388367dd73102a2 Cr-Commit-Position: refs/heads/master@{#12765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M webrtc/media/engine/fakewebrtcvideocapturemodule.h View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nisse-webrtc
4 years, 7 months ago (2016-05-16 13:21:13 UTC) #2
magjed_webrtc
lgtm
4 years, 7 months ago (2016-05-16 13:22:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985693002/1
4 years, 7 months ago (2016-05-16 13:30:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-16 15:32:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985693002/1
4 years, 7 months ago (2016-05-17 06:46:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 06:51:09 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 06:51:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/744494f451e98680895f62e85388367dd73102a2
Cr-Commit-Position: refs/heads/master@{#12765}

Powered by Google App Engine
This is Rietveld 408576698