Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: webrtc/config.h

Issue 1984983002: Remove use of RtpHeaderExtension and clean up (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/config.h
diff --git a/webrtc/config.h b/webrtc/config.h
index 06460ae359641a533c7fdc4615e51637e72fb2ba..6350525841c19aa6d955e189c772f75b9d988556 100644
--- a/webrtc/config.h
+++ b/webrtc/config.h
@@ -52,20 +52,31 @@ struct FecConfig {
// RTP header extension, see RFC 5285.
struct RtpExtension {
- RtpExtension(const std::string& name, int id) : name(name), id(id) {}
+ RtpExtension() : id(0) {}
+ RtpExtension(const std::string& uri, int id) : uri(uri), id(id) {}
std::string ToString() const;
bool operator==(const RtpExtension& rhs) const {
- return name == rhs.name && id == rhs.id;
+ return uri == rhs.uri && id == rhs.id;
}
- static bool IsSupportedForAudio(const std::string& name);
- static bool IsSupportedForVideo(const std::string& name);
-
- static const char* kTOffset;
- static const char* kAbsSendTime;
- static const char* kVideoRotation;
- static const char* kAudioLevel;
- static const char* kTransportSequenceNumber;
- std::string name;
+ static bool IsSupportedForAudio(const std::string& uri);
+ static bool IsSupportedForVideo(const std::string& uri);
+
+ static const char* kAudioLevelUri;
perkj_webrtc 2016/05/19 16:40:59 please add the links to the description that you r
Irfan 2016/05/19 16:54:58 Done.
+ static const int kAudioLevelDefaultId;
+
+ static const char* kTimestampOffsetUri;
+ static const int kTimestampOffsetDefaultId;
+
+ static const char* kAbsSendTimeUri;
+ static const int kAbsSendTimeDefaultId;
+
+ static const char* kVideoRotationUri;
+ static const int kVideoRotationDefaultId;
+
+ static const char* kTransportSequenceNumberUri;
+ static const int kTransportSequenceNumberDefaultId;
+
+ std::string uri;
int id;
};

Powered by Google App Engine
This is Rietveld 408576698