Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: webrtc/video/video_send_stream_tests.cc

Issue 1984983002: Remove use of RtpHeaderExtension and clean up (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« webrtc/pc/mediasession.h ('K') | « webrtc/video/video_send_stream.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> // max 10 #include <algorithm> // max
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 return SEND_PACKET; 141 return SEND_PACKET;
142 } 142 }
143 143
144 void ModifyVideoConfigs( 144 void ModifyVideoConfigs(
145 VideoSendStream::Config* send_config, 145 VideoSendStream::Config* send_config,
146 std::vector<VideoReceiveStream::Config>* receive_configs, 146 std::vector<VideoReceiveStream::Config>* receive_configs,
147 VideoEncoderConfig* encoder_config) override { 147 VideoEncoderConfig* encoder_config) override {
148 send_config->rtp.extensions.clear(); 148 send_config->rtp.extensions.clear();
149 send_config->rtp.extensions.push_back(RtpExtension( 149 send_config->rtp.extensions.push_back(RtpExtension(
150 RtpExtension::kAbsSendTime, test::kAbsSendTimeExtensionId)); 150 RtpExtension::kAbsSendTimeUri, test::kAbsSendTimeExtensionId));
151 } 151 }
152 152
153 void PerformTest() override { 153 void PerformTest() override {
154 EXPECT_TRUE(Wait()) << "Timed out while waiting for single RTP packet."; 154 EXPECT_TRUE(Wait()) << "Timed out while waiting for single RTP packet.";
155 } 155 }
156 } test; 156 } test;
157 157
158 RunBaseTest(&test); 158 RunBaseTest(&test);
159 } 159 }
160 160
(...skipping 21 matching lines...) Expand all
182 182
183 return SEND_PACKET; 183 return SEND_PACKET;
184 } 184 }
185 185
186 void ModifyVideoConfigs( 186 void ModifyVideoConfigs(
187 VideoSendStream::Config* send_config, 187 VideoSendStream::Config* send_config,
188 std::vector<VideoReceiveStream::Config>* receive_configs, 188 std::vector<VideoReceiveStream::Config>* receive_configs,
189 VideoEncoderConfig* encoder_config) override { 189 VideoEncoderConfig* encoder_config) override {
190 send_config->encoder_settings.encoder = &encoder_; 190 send_config->encoder_settings.encoder = &encoder_;
191 send_config->rtp.extensions.clear(); 191 send_config->rtp.extensions.clear();
192 send_config->rtp.extensions.push_back( 192 send_config->rtp.extensions.push_back(RtpExtension(
193 RtpExtension(RtpExtension::kTOffset, test::kTOffsetExtensionId)); 193 RtpExtension::kTimestampOffsetUri, test::kTOffsetExtensionId));
194 } 194 }
195 195
196 void PerformTest() override { 196 void PerformTest() override {
197 EXPECT_TRUE(Wait()) << "Timed out while waiting for a single RTP packet."; 197 EXPECT_TRUE(Wait()) << "Timed out while waiting for a single RTP packet.";
198 } 198 }
199 199
200 test::DelayedEncoder encoder_; 200 test::DelayedEncoder encoder_;
201 } test; 201 } test;
202 202
203 RunBaseTest(&test); 203 RunBaseTest(&test);
(...skipping 22 matching lines...) Expand all
226 226
227 return SEND_PACKET; 227 return SEND_PACKET;
228 } 228 }
229 229
230 void ModifyVideoConfigs( 230 void ModifyVideoConfigs(
231 VideoSendStream::Config* send_config, 231 VideoSendStream::Config* send_config,
232 std::vector<VideoReceiveStream::Config>* receive_configs, 232 std::vector<VideoReceiveStream::Config>* receive_configs,
233 VideoEncoderConfig* encoder_config) override { 233 VideoEncoderConfig* encoder_config) override {
234 send_config->encoder_settings.encoder = &encoder_; 234 send_config->encoder_settings.encoder = &encoder_;
235 send_config->rtp.extensions.clear(); 235 send_config->rtp.extensions.clear();
236 send_config->rtp.extensions.push_back( 236 send_config->rtp.extensions.push_back(RtpExtension(
237 RtpExtension(RtpExtension::kTransportSequenceNumber, kExtensionId)); 237 RtpExtension::kTransportSequenceNumberUri, kExtensionId));
238 } 238 }
239 239
240 void PerformTest() override { 240 void PerformTest() override {
241 EXPECT_TRUE(Wait()) << "Timed out while waiting for a single RTP packet."; 241 EXPECT_TRUE(Wait()) << "Timed out while waiting for a single RTP packet.";
242 } 242 }
243 243
244 test::FakeEncoder encoder_; 244 test::FakeEncoder encoder_;
245 } test; 245 } test;
246 246
247 RunBaseTest(&test); 247 RunBaseTest(&test);
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 VideoSendStreamTest::kNackRtpHistoryMs; 415 VideoSendStreamTest::kNackRtpHistoryMs;
416 } 416 }
417 send_config->encoder_settings.encoder = encoder_.get(); 417 send_config->encoder_settings.encoder = encoder_.get();
418 send_config->encoder_settings.payload_name = payload_name_; 418 send_config->encoder_settings.payload_name = payload_name_;
419 send_config->rtp.fec.red_payload_type = 419 send_config->rtp.fec.red_payload_type =
420 VideoSendStreamTest::kRedPayloadType; 420 VideoSendStreamTest::kRedPayloadType;
421 send_config->rtp.fec.ulpfec_payload_type = 421 send_config->rtp.fec.ulpfec_payload_type =
422 VideoSendStreamTest::kUlpfecPayloadType; 422 VideoSendStreamTest::kUlpfecPayloadType;
423 if (header_extensions_enabled_) { 423 if (header_extensions_enabled_) {
424 send_config->rtp.extensions.push_back(RtpExtension( 424 send_config->rtp.extensions.push_back(RtpExtension(
425 RtpExtension::kAbsSendTime, test::kAbsSendTimeExtensionId)); 425 RtpExtension::kAbsSendTimeUri, test::kAbsSendTimeExtensionId));
426 send_config->rtp.extensions.push_back( 426 send_config->rtp.extensions.push_back(
427 RtpExtension(RtpExtension::kTransportSequenceNumber, 427 RtpExtension(RtpExtension::kTransportSequenceNumberUri,
428 test::kTransportSequenceNumberExtensionId)); 428 test::kTransportSequenceNumberExtensionId));
429 } 429 }
430 (*receive_configs)[0].rtp.fec.red_payload_type = 430 (*receive_configs)[0].rtp.fec.red_payload_type =
431 send_config->rtp.fec.red_payload_type; 431 send_config->rtp.fec.red_payload_type;
432 (*receive_configs)[0].rtp.fec.ulpfec_payload_type = 432 (*receive_configs)[0].rtp.fec.ulpfec_payload_type =
433 send_config->rtp.fec.ulpfec_payload_type; 433 send_config->rtp.fec.ulpfec_payload_type;
434 } 434 }
435 435
436 void PerformTest() override { 436 void PerformTest() override {
437 EXPECT_TRUE(Wait()) << "Timed out waiting for FEC and media packets."; 437 EXPECT_TRUE(Wait()) << "Timed out waiting for FEC and media packets.";
(...skipping 1854 matching lines...) Expand 10 before | Expand all | Expand 10 after
2292 observation_complete_.Set(); 2292 observation_complete_.Set();
2293 } 2293 }
2294 } 2294 }
2295 } test; 2295 } test;
2296 2296
2297 RunBaseTest(&test); 2297 RunBaseTest(&test);
2298 } 2298 }
2299 #endif // !defined(RTC_DISABLE_VP9) 2299 #endif // !defined(RTC_DISABLE_VP9)
2300 2300
2301 } // namespace webrtc 2301 } // namespace webrtc
OLDNEW
« webrtc/pc/mediasession.h ('K') | « webrtc/video/video_send_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698