Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1984653002: Added support in the AEC for refined filter adaptation. (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@50
Target Ref:
refs/pending/branch-heads/50
Project:
webrtc
Visibility:
Public.

Description

Added support in the AEC for refined filter adaptation. The following algorithmic functionality was added: -Add support for an exact regressor power to be computed which avoids the issue with the updating of the filter sometimes being unstable. -Lowered the fixed step size of the adaptive filter to 0.05 which significantly reduces the sensitivity of the adaptive filter to near-end noise, nonlinearities, doubletalk and the unmodelled echo path tail. It also reduces the tracking speed of the adaptive filter but the chosen value proved to give a sufficient tradeoff for the requirements on the adaptive filter. To allow the new functionality to be selectively applied the following was done: -A new Config was added for selectively activating the functionality. -Functionality was added in the audioprocessing and echocancellationimpl classes for passing the activation of the functionality down to the AEC algorithms. To make the code for the introduction of the functionality clean, the following refactoring was done: -The selection of the step size was moved to a single place. -The constant for the step size of the adaptive filter in extended filter mode was made local. -The state variable storing the step-size was renamed to a more describing name. When the new functionality is not activated, the changes have been tested for bitexactness on Linux. BUG=webrtc:5778, webrtc:5777, chromium:603411 Review URL: https://codereview.webrtc.org/1887003002 Cr-Commit-Position: refs/heads/master@{#12384} R=peah@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/49f7bd357dafab4f7e3e1cd5fbe8d9cbf5730057

Patch Set 1 #

Patch Set 2 : One fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -63 lines) Patch
M webrtc/common.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 9 chunks +109 lines, -25 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_internal.h View 4 chunks +6 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hlundin-webrtc
peah, PTAL at this merge CL.
4 years, 7 months ago (2016-05-16 12:23:01 UTC) #2
hlundin-webrtc
One fix
4 years, 7 months ago (2016-05-16 12:26:18 UTC) #3
peah-webrtc
Awesome! lgtm
4 years, 7 months ago (2016-05-16 12:39:48 UTC) #4
hlundin-webrtc
4 years, 7 months ago (2016-05-16 13:04:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
49f7bd357dafab4f7e3e1cd5fbe8d9cbf5730057.

Powered by Google App Engine
This is Rietveld 408576698