base.gyp: Add conditions for NaCl builds.

base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.
See https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=260 for details.

BUG=webrtc:4256
R=perkj@webrtc.org

Committed: https://crrev.com/03d45b016a484c10fc90a81a604e60be2f420b7e
Cr-Commit-Position: refs/heads/master@{#12819}

[kjellander_webrtc, 2016-05-16 07:47:32]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-05-16 07:48:56]

Description was changed from

==========
base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.

BUG=webrtc:4256
==========

to

==========
base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
for details.

BUG=webrtc:4256
==========

[kjellander_webrtc, 2016-05-16 07:57:03]

kjellander@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kjellander_webrtc, 2016-05-16 08:37:59]

Please ignore the red bot, I shouldn't have triggered it.

[perkj_webrtc, 2016-05-16 12:37:21]

lgtm with comment below addressed.

https://codereview.webrtc.org/1984613002/diff/20001/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/1984613002/diff/20001/webrtc/build/common.gypi#...
webrtc/build/common.gypi:96: # Targets are by default not NaCl untrusted code.
Can you add a little bit more descriptive text what nacl_untrusted_build is?

[kjellander_webrtc, 2016-05-20 07:16:33]

Improved docs in PS#2. Will test this on my machine now.

https://codereview.webrtc.org/1984613002/diff/20001/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/1984613002/diff/20001/webrtc/build/common.gypi#...
webrtc/build/common.gypi:96: # Targets are by default not NaCl untrusted code.
On 2016/05/16 12:37:20, perkj_webrtc wrote:
> Can you add a little bit more descriptive text what nacl_untrusted_build is?

Done.

[kjellander_webrtc, 2016-05-20 07:43:59]

On 2016/05/20 07:16:33, kjellander (webrtc) wrote:
> Improved docs in PS#2. Will test this on my machine now.

Actually, I don't have much clue about how to test the NaCl build, so I'll
submit this now and try triggering as many NaCl trybots I can find in a roll-CL
instead (although rolling is now blocked due to pending Chrome branch cut).

> 
> https://codereview.webrtc.org/1984613002/diff/20001/webrtc/build/common.gypi
> File webrtc/build/common.gypi (right):
> 
>
https://codereview.webrtc.org/1984613002/diff/20001/webrtc/build/common.gypi#...
> webrtc/build/common.gypi:96: # Targets are by default not NaCl untrusted code.
> On 2016/05/16 12:37:20, perkj_webrtc wrote:
> > Can you add a little bit more descriptive text what nacl_untrusted_build is?
> 
> Done.

[kjellander_webrtc, 2016-05-20 07:52:53]

Description was changed from

==========
base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
for details.

BUG=webrtc:4256
==========

to

==========
base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
for details.

BUG=webrtc:4256
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/03d45b016a484c10fc90a81a6...
==========

[kjellander_webrtc, 2016-05-20 07:52:54]

Committed patchset #2 (id:40001) manually as
03d45b016a484c10fc90a81a604e60be2f420b7e (presubmit successful).

[commit-bot: I haz the power, 2016-05-20 07:52:57]

Description was changed from

==========
base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
for details.

BUG=webrtc:4256
R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/03d45b016a484c10fc90a81a6...
==========

to

==========
base.gyp: Add conditions for NaCl builds.

These are needed to be able to cleanup the NaCl
GYP code in src/third_party/libjingle before switching
over to WebRTC's own targets.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
for details.

BUG=webrtc:4256
R=perkj@webrtc.org

Committed: https://crrev.com/03d45b016a484c10fc90a81a604e60be2f420b7e
Cr-Commit-Position: refs/heads/master@{#12819}
==========