Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1984573003: Reland of landing: Implement RTCConfiguration.iceCandidatePoolSize. (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Implement RTCConfiguration.iceCandidatePoolSize. (https://codereview.webrtc.org/1956453003/ ) > Original issue's description: > > Relanding: Implement RTCConfiguration.iceCandidatePoolSize. > > > > Depends on this CL in order to work in Chromium: > > https://codereview.chromium.org/1976673002/ > > > > It works by creating pooled PortAllocatorSessions which can be picked up > > by a P2PTransportChannel when needed (after a local description is set). > > > > This can optimize candidate gathering time when there is some time between > > creating a PeerConnection and setting a local description. > > > > R=pthatcher@webrtc.org > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944008f75825971802 > > > > Committed: https://crrev.com/a1c303535fe7a29b87879047996efa2952f9701b > > Cr-Commit-Position: refs/heads/master@{#12729} TBR=pthatcher@webrtc.org,honghaiz@webrtc.org,deadbeef@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2617 lines, -1914 lines) Patch
M webrtc/api/peerconnection.h View 4 chunks +9 lines, -5 lines 0 comments Download
M webrtc/api/peerconnection.cc View 5 chunks +96 lines, -37 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 chunk +13 lines, -25 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 6 chunks +92 lines, -16 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsession.h View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 4 chunks +0 lines, -25 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 2 chunks +0 lines, -50 lines 0 comments Download
M webrtc/p2p/base/candidate.h View 1 chunk +13 lines, -0 lines 0 comments Download
A webrtc/p2p/base/fakeportallocator.h View 1 chunk +220 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 3 chunks +32 lines, -16 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 5 chunks +92 lines, -2 lines 0 comments Download
M webrtc/p2p/base/port.h View 2 chunks +12 lines, -14 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 12 chunks +102 lines, -18 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 chunk +69 lines, -7 lines 0 comments Download
A webrtc/p2p/base/portallocator_unittest.cc View 1 chunk +205 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 5 chunks +14 lines, -27 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 13 chunks +105 lines, -57 lines 0 comments Download
A webrtc/p2p/client/basicportallocator_unittest.cc View 1 chunk +1500 lines, -0 lines 0 comments Download
D webrtc/p2p/client/fakeportallocator.h View 1 chunk +0 lines, -189 lines 0 comments Download
D webrtc/p2p/client/portallocator_unittest.cc View 1 chunk +0 lines, -1412 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tommi
Created Reland of landing: Implement RTCConfiguration.iceCandidatePoolSize.
4 years, 7 months ago (2016-05-16 18:52:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984573003/1
4 years, 7 months ago (2016-05-16 18:54:13 UTC) #4
tommi
4 years, 7 months ago (2016-05-16 18:54:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:55:24 UTC) #7
Try jobs failed on following builders:
  android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  android_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/1...)
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/14753)
  linux_libfuzzer_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  linux_tsan2 on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/12205)
  linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

Powered by Google App Engine
This is Rietveld 408576698