Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1984383002: MIPS64: Do not use openmax_dl for MIPS64 in GN (Closed)

Created:
4 years, 7 months ago by gordanac
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, petar.jovanovic
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MIPS64: Do not use openmax_dl for MIPS64 in GN Disables openmax_dl for MIPS64 as it is not supported. BUG=linker reports error about missing openmax_dl symbols NOTRY=True Committed: https://crrev.com/caea17a139da8aaaef316a5786c93ec99dc8de75 Cr-Commit-Position: refs/heads/master@{#12982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M webrtc/build/webrtc.gni View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
gordanac
Please take a look. Disabling openmax_dl for mips64 in GN. Similar was done last year ...
4 years, 7 months ago (2016-05-17 17:51:11 UTC) #2
ljubomir.papuga1
lgtm
4 years, 7 months ago (2016-05-20 12:04:07 UTC) #4
gordanac
@ajm, just a friendly reminder.
4 years, 7 months ago (2016-05-24 12:28:03 UTC) #5
gordanac
+kjellander I need OWNER's approval.
4 years, 6 months ago (2016-05-31 16:06:03 UTC) #7
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-05-31 20:01:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984383002/1
4 years, 6 months ago (2016-06-01 07:52:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 07:53:40 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 07:53:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caea17a139da8aaaef316a5786c93ec99dc8de75
Cr-Commit-Position: refs/heads/master@{#12982}

Powered by Google App Engine
This is Rietveld 408576698