Add muted parameter to audio_frame_manipulator methods

Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
NOTRY=True

Committed: https://crrev.com/5a216d0489b2374a778c90e657fb71a6def5d1a1
Cr-Commit-Position: refs/heads/master@{#12788}

[hlundin-webrtc, 2016-05-17 10:28:20]

henrik.lundin@webrtc.org changed reviewers:
+ minyue@webrtc.org

[hlundin-webrtc, 2016-05-17 10:28:21]

Minyue, PTAL at this CL.

Thanks!

[minyue-webrtc, 2016-05-17 15:22:42]

This looks good. But if I were you, I might consider adding if muted at the
caller's place, since if feels a bit awkward that we call ramp-in / out etc even
if it is muted.

[hlundin-webrtc, 2016-05-17 19:26:09]

Avoid calling frame manipulator functions when muted

[hlundin-webrtc, 2016-05-17 19:29:54]

I changed according to your recommendation, and agree that it is much nicer.
Thanks!

https://codereview.webrtc.org/1983023002/diff/20001/webrtc/modules/audio_conf...
File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc
(right):

https://codereview.webrtc.org/1983023002/diff/20001/webrtc/modules/audio_conf...
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc:625:
if (replaceWasMixed) {
The formatting is "all over the place" in this file. In the scope of this
if-statement, 2-space indentation is used, so I stuck with that. For the rest of
my changes to this file, 4-space seems to be the rule.

[minyue-webrtc, 2016-05-18 01:34:45]

lgtm

https://codereview.webrtc.org/1983023002/diff/20001/webrtc/modules/audio_conf...
File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc
(right):

https://codereview.webrtc.org/1983023002/diff/20001/webrtc/modules/audio_conf...
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc:625:
if (replaceWasMixed) {
On 2016/05/17 19:29:54, hlundin-webrtc wrote:
> The formatting is "all over the place" in this file. In the scope of this
> if-statement, 2-space indentation is used, so I stuck with that. For the rest
of
> my changes to this file, 4-space seems to be the rule.

Acknowledged but it is weird

[hlundin-webrtc, 2016-05-18 09:32:11]

Description was changed from

==========
Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
==========

to

==========
Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
NOTRY=True
==========

[hlundin-webrtc, 2016-05-18 09:32:18]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-05-18 09:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1983023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1983023002/20001

[commit-bot: I haz the power, 2016-05-18 09:34:20]

Description was changed from

==========
Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
NOTRY=True
==========

to

==========
Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
NOTRY=True
==========

[commit-bot: I haz the power, 2016-05-18 09:34:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 09:34:29]

Description was changed from

==========
Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
NOTRY=True
==========

to

==========
Add muted parameter to audio_frame_manipulator methods

BUG=webrtc:5609
NOTRY=True

Committed: https://crrev.com/5a216d0489b2374a778c90e657fb71a6def5d1a1
Cr-Commit-Position: refs/heads/master@{#12788}
==========

[commit-bot: I haz the power, 2016-05-18 09:34:30]

Patchset 2 (id:??) landed as
https://crrev.com/5a216d0489b2374a778c90e657fb71a6def5d1a1
Cr-Commit-Position: refs/heads/master@{#12788}