Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: webrtc/base/socket_unittest.cc

Issue 1982733002: Re-enabling socket tests that were previously flaky. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing ifdefs. Using same logic as network.cc. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/physicalsocketserver_unittest.cc ('k') | webrtc/base/testclient.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2007 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2007 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <memory> 11 #include <memory>
12 12
13 #include "webrtc/base/socket_unittest.h" 13 #include "webrtc/base/socket_unittest.h"
14 14
15 #include "webrtc/base/arraysize.h" 15 #include "webrtc/base/arraysize.h"
16 #include "webrtc/base/buffer.h" 16 #include "webrtc/base/buffer.h"
17 #include "webrtc/base/asyncudpsocket.h" 17 #include "webrtc/base/asyncudpsocket.h"
18 #include "webrtc/base/gunit.h" 18 #include "webrtc/base/gunit.h"
19 #include "webrtc/base/nethelpers.h" 19 #include "webrtc/base/nethelpers.h"
20 #include "webrtc/base/socketserver.h" 20 #include "webrtc/base/socketserver.h"
21 #include "webrtc/base/testclient.h" 21 #include "webrtc/base/testclient.h"
22 #include "webrtc/base/testutils.h" 22 #include "webrtc/base/testutils.h"
23 #include "webrtc/base/thread.h" 23 #include "webrtc/base/thread.h"
24 24
25 namespace rtc { 25 namespace rtc {
26 26
27 // Data size to be used in TcpInternal tests.
28 static const size_t kTcpInternalDataSize = 1024 * 1024; // bytes
29
30 #define MAYBE_SKIP_IPV6 \ 27 #define MAYBE_SKIP_IPV6 \
31 if (!HasIPv6Enabled()) { \ 28 if (!HasIPv6Enabled()) { \
32 LOG(LS_INFO) << "No IPv6... skipping"; \ 29 LOG(LS_INFO) << "No IPv6... skipping"; \
33 return; \ 30 return; \
34 } 31 }
35 32
33 // Data size to be used in TcpInternal tests.
34 static const size_t kTcpInternalDataSize = 1024 * 1024; // bytes
36 35
37 void SocketTest::TestConnectIPv4() { 36 void SocketTest::TestConnectIPv4() {
38 ConnectInternal(kIPv4Loopback); 37 ConnectInternal(kIPv4Loopback);
39 } 38 }
40 39
41 void SocketTest::TestConnectIPv6() { 40 void SocketTest::TestConnectIPv6() {
42 MAYBE_SKIP_IPV6; 41 MAYBE_SKIP_IPV6;
43 ConnectInternal(kIPv6Loopback); 42 ConnectInternal(kIPv6Loopback);
44 } 43 }
45 44
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 ASSERT_EQ(-1, mtu_socket->EstimateMTU(&mtu)); 1017 ASSERT_EQ(-1, mtu_socket->EstimateMTU(&mtu));
1019 #else 1018 #else
1020 // and the behavior seems unpredictable on Linux, 1019 // and the behavior seems unpredictable on Linux,
1021 // failing on the build machine 1020 // failing on the build machine
1022 // but succeeding on my Ubiquity instance. 1021 // but succeeding on my Ubiquity instance.
1023 #endif 1022 #endif
1024 } 1023 }
1025 } 1024 }
1026 1025
1027 } // namespace rtc 1026 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/physicalsocketserver_unittest.cc ('k') | webrtc/base/testclient.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698