Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1982713002: Revert of Increase the stun ping interval. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Increase the stun ping interval. (patchset #5 id:80001 of https://codereview.webrtc.org/1944003002/ ) Reason for revert: This will take longer time for the RTT to converge. Need to update the RTT calculation algorithm if doing this. Original issue's description: > Increase the stun ping interval. > > Writable connections are pinged at a slower rate. > The function IsPingable will filter out the writable connections. > The interval for slower ping rate by default is WRITABLE_CONNECTION_PING_INTERVAL(2500ms) and can be set with the configuration. > > BUG=webrtc:1161 > > Committed: https://crrev.com/8f7a5aad55a64f0d81b6436a22ffbdfcdcde91e0 > Cr-Commit-Position: refs/heads/master@{#12736} TBR=honghaiz@webrtc.org,pthatcher@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:1161 Committed: https://crrev.com/2abe42741743bd8eeaf37350acb20b4a10b7901e Cr-Commit-Position: refs/heads/master@{#12762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.cc View 6 chunks +11 lines, -20 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transport.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Taylor Brandstetter
Created Revert of Increase the stun ping interval.
4 years, 7 months ago (2016-05-16 18:16:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982713002/1
4 years, 7 months ago (2016-05-16 18:16:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982713002/1
4 years, 7 months ago (2016-05-16 18:31:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982713002/1
4 years, 7 months ago (2016-05-16 19:01:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982713002/1
4 years, 7 months ago (2016-05-16 19:31:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982713002/1
4 years, 7 months ago (2016-05-16 20:01:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-16 20:16:50 UTC) #8
Taylor Brandstetter
4 years, 7 months ago (2016-05-16 21:12:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2abe42741743bd8eeaf37350acb20b4a10b7901e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698