Revert of Relanding: Implement RTCConfiguration.iceCandidatePoolSize.

Revert of Relanding: Implement RTCConfiguration.iceCandidatePoolSize. (patchset #7 id:120001 of https://codereview.webrtc.org/1956453003/ )

Reason for revert:
Speculative revert to see if this could be triggering an error on the Memcheck build bot where EndToEndTest.SendsAndReceivesH264 consistently times out:

https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck



Original issue's description:
> Relanding: Implement RTCConfiguration.iceCandidatePoolSize.
> 
> Depends on this CL in order to work in Chromium:
> https://codereview.chromium.org/1976673002/
> 
> It works by creating pooled PortAllocatorSessions which can be picked up
> by a P2PTransportChannel when needed (after a local description is set).
> 
> This can optimize candidate gathering time when there is some time between
> creating a PeerConnection and setting a local description.
> 
> R=pthatcher@webrtc.org
> 
> Committed: https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944008f75825971802
> 
> Committed: https://crrev.com/a1c303535fe7a29b87879047996efa2952f9701b
> Cr-Commit-Position: refs/heads/master@{#12729}

TBR=pthatcher@webrtc.org,honghaiz@webrtc.org,deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

[tommi, 2016-05-14 10:23:46]

Created Revert of Relanding: Implement RTCConfiguration.iceCandidatePoolSize.

[commit-bot: I haz the power, 2016-05-14 10:23:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1982513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1982513002/1

[commit-bot: I haz the power, 2016-05-14 10:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 10:24:06]

Failed to apply patch for webrtc/p2p/p2p.gyp:
While running git apply --index -3 -p1;
  error: patch failed: webrtc/p2p/p2p.gyp:177
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: webrtc/p2p/p2p.gyp: patch does not apply

Patch:       webrtc/p2p/p2p.gyp
Index: webrtc/p2p/p2p.gyp
diff --git a/webrtc/p2p/p2p.gyp b/webrtc/p2p/p2p.gyp
index
537c5d186fdfc996952f0a51574c2ce0e0480a79..50941c86827fcbc65317177f4c13ee91f3941cbd
100644
--- a/webrtc/p2p/p2p.gyp
+++ b/webrtc/p2p/p2p.gyp
@@ -158,11 +158,9 @@
           'direct_dependent_settings': {
             'sources': [
               'base/dtlstransportchannel_unittest.cc',
-              'base/fakeportallocator.h',
               'base/faketransportcontroller.h',
               'base/p2ptransportchannel_unittest.cc',
               'base/port_unittest.cc',
-              'base/portallocator_unittest.cc',
               'base/pseudotcp_unittest.cc',
               'base/relayport_unittest.cc',
               'base/relayserver_unittest.cc',
@@ -177,7 +175,8 @@
               'base/transportcontroller_unittest.cc',
               'base/transportdescriptionfactory_unittest.cc',
               'base/turnport_unittest.cc',
-              'client/basicportallocator_unittest.cc',
+              'client/fakeportallocator.h',
+              'client/portallocator_unittest.cc',
               'stunprober/stunprober_unittest.cc',
             ],
             'conditions': [

[commit-bot: I haz the power, 2016-05-14 10:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[tommi, 2016-05-14 10:26:58]

On 2016/05/14 10:24:06, commit-bot: I haz the power wrote:
> Failed to apply patch for webrtc/p2p/p2p.gyp:
> While running git apply --index -3 -p1;
>   error: patch failed: webrtc/p2p/p2p.gyp:177
>   error: repository lacks the necessary blob to fall back on 3-way merge.
>   error: webrtc/p2p/p2p.gyp: patch does not apply
> 
> Patch:       webrtc/p2p/p2p.gyp
> Index: webrtc/p2p/p2p.gyp
> diff --git a/webrtc/p2p/p2p.gyp b/webrtc/p2p/p2p.gyp
> index
>
537c5d186fdfc996952f0a51574c2ce0e0480a79..50941c86827fcbc65317177f4c13ee91f3941cbd
> 100644
> --- a/webrtc/p2p/p2p.gyp
> +++ b/webrtc/p2p/p2p.gyp
> @@ -158,11 +158,9 @@
>            'direct_dependent_settings': {
>              'sources': [
>                'base/dtlstransportchannel_unittest.cc',
> -              'base/fakeportallocator.h',
>                'base/faketransportcontroller.h',
>                'base/p2ptransportchannel_unittest.cc',
>                'base/port_unittest.cc',
> -              'base/portallocator_unittest.cc',
>                'base/pseudotcp_unittest.cc',
>                'base/relayport_unittest.cc',
>                'base/relayserver_unittest.cc',
> @@ -177,7 +175,8 @@
>                'base/transportcontroller_unittest.cc',
>                'base/transportdescriptionfactory_unittest.cc',
>                'base/turnport_unittest.cc',
> -              'client/basicportallocator_unittest.cc',
> +              'client/fakeportallocator.h',
> +              'client/portallocator_unittest.cc',
>                'stunprober/stunprober_unittest.cc',
>              ],
>              'conditions': [

Taylor - I'm going to close this cl and not attempt the revert, but can you
check if your cl may have caused this test to start failing?  I've looked at all
the other CLs on the blamelist and yours was the last one I'm looking at.

[Taylor Brandstetter, 2016-05-16 17:38:46]

On 2016/05/14 10:26:58, tommi-webrtc wrote:
> On 2016/05/14 10:24:06, commit-bot: I haz the power wrote:
> > Failed to apply patch for webrtc/p2p/p2p.gyp:
> > While running git apply --index -3 -p1;
> >   error: patch failed: webrtc/p2p/p2p.gyp:177
> >   error: repository lacks the necessary blob to fall back on 3-way merge.
> >   error: webrtc/p2p/p2p.gyp: patch does not apply
> > 
> > Patch:       webrtc/p2p/p2p.gyp
> > Index: webrtc/p2p/p2p.gyp
> > diff --git a/webrtc/p2p/p2p.gyp b/webrtc/p2p/p2p.gyp
> > index
> >
>
537c5d186fdfc996952f0a51574c2ce0e0480a79..50941c86827fcbc65317177f4c13ee91f3941cbd
> > 100644
> > --- a/webrtc/p2p/p2p.gyp
> > +++ b/webrtc/p2p/p2p.gyp
> > @@ -158,11 +158,9 @@
> >            'direct_dependent_settings': {
> >              'sources': [
> >                'base/dtlstransportchannel_unittest.cc',
> > -              'base/fakeportallocator.h',
> >                'base/faketransportcontroller.h',
> >                'base/p2ptransportchannel_unittest.cc',
> >                'base/port_unittest.cc',
> > -              'base/portallocator_unittest.cc',
> >                'base/pseudotcp_unittest.cc',
> >                'base/relayport_unittest.cc',
> >                'base/relayserver_unittest.cc',
> > @@ -177,7 +175,8 @@
> >                'base/transportcontroller_unittest.cc',
> >                'base/transportdescriptionfactory_unittest.cc',
> >                'base/turnport_unittest.cc',
> > -              'client/basicportallocator_unittest.cc',
> > +              'client/fakeportallocator.h',
> > +              'client/portallocator_unittest.cc',
> >                'stunprober/stunprober_unittest.cc',
> >              ],
> >              'conditions': [
> 
> Taylor - I'm going to close this cl and not attempt the revert, but can you
> check if your cl may have caused this test to start failing?  I've looked at
all
> the other CLs on the blamelist and yours was the last one I'm looking at.

It looks like this has been resolved by pbos@, correct?

[tommi, 2016-05-16 18:51:50]

On 2016/05/16 17:38:46, Taylor Brandstetter wrote:
> On 2016/05/14 10:26:58, tommi-webrtc wrote:
> > On 2016/05/14 10:24:06, commit-bot: I haz the power wrote:
> > > Failed to apply patch for webrtc/p2p/p2p.gyp:
> > > While running git apply --index -3 -p1;
> > >   error: patch failed: webrtc/p2p/p2p.gyp:177
> > >   error: repository lacks the necessary blob to fall back on 3-way merge.
> > >   error: webrtc/p2p/p2p.gyp: patch does not apply
> > > 
> > > Patch:       webrtc/p2p/p2p.gyp
> > > Index: webrtc/p2p/p2p.gyp
> > > diff --git a/webrtc/p2p/p2p.gyp b/webrtc/p2p/p2p.gyp
> > > index
> > >
> >
>
537c5d186fdfc996952f0a51574c2ce0e0480a79..50941c86827fcbc65317177f4c13ee91f3941cbd
> > > 100644
> > > --- a/webrtc/p2p/p2p.gyp
> > > +++ b/webrtc/p2p/p2p.gyp
> > > @@ -158,11 +158,9 @@
> > >            'direct_dependent_settings': {
> > >              'sources': [
> > >                'base/dtlstransportchannel_unittest.cc',
> > > -              'base/fakeportallocator.h',
> > >                'base/faketransportcontroller.h',
> > >                'base/p2ptransportchannel_unittest.cc',
> > >                'base/port_unittest.cc',
> > > -              'base/portallocator_unittest.cc',
> > >                'base/pseudotcp_unittest.cc',
> > >                'base/relayport_unittest.cc',
> > >                'base/relayserver_unittest.cc',
> > > @@ -177,7 +175,8 @@
> > >                'base/transportcontroller_unittest.cc',
> > >                'base/transportdescriptionfactory_unittest.cc',
> > >                'base/turnport_unittest.cc',
> > > -              'client/basicportallocator_unittest.cc',
> > > +              'client/fakeportallocator.h',
> > > +              'client/portallocator_unittest.cc',
> > >                'stunprober/stunprober_unittest.cc',
> > >              ],
> > >              'conditions': [
> > 
> > Taylor - I'm going to close this cl and not attempt the revert, but can you
> > check if your cl may have caused this test to start failing?  I've looked at
> all
> > the other CLs on the blamelist and yours was the last one I'm looking at.
> 
> It looks like this has been resolved by pbos@, correct?

Yes, relanding now.

[tommi, 2016-05-16 18:52:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1984573003/ by tommi@webrtc.org.

The reason for reverting is: Relanding.

[Taylor Brandstetter, 2016-05-16 20:01:08]

On 2016/05/16 18:52:27, tommi-webrtc wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.webrtc.org/1984573003/ by mailto:tommi@webrtc.org.
> 
> The reason for reverting is: Relanding.

No need to reland since it wasn't actually reverted; I just wanted to make sure
I didn't need to revert it after all.

[tommi, 2016-05-16 20:02:43]

On 2016/05/16 20:01:08, Taylor Brandstetter wrote:
> On 2016/05/16 18:52:27, tommi-webrtc wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.webrtc.org/1984573003/ by mailto:tommi@webrtc.org.
> > 
> > The reason for reverting is: Relanding.
> 
> No need to reland since it wasn't actually reverted; I just wanted to make
sure
> I didn't need to revert it after all.

ah, thanks