webrtc/modules/audio_processing/include/audio_processing.h - Issue 1982183002: Pull out the PostFilter to its own NonlinearBeamformer API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 1982183002: Pull out the PostFilter to its own NonlinearBeamformer API (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Drop Beamformer Interface Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc ('K') | « webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc ('k') | webrtc/modules/audio_processing/splitting_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/include/audio_processing.h

diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h

index 24be9de262247d6fc649ab46fb78f2addfe4574c..e1d90e5518c8c7078994b0caa2c1024002ebc868 100644

--- a/webrtc/modules/audio_processing/include/audio_processing.h

+++ b/webrtc/modules/audio_processing/include/audio_processing.h

@@ -31,8 +31,7 @@ struct AecCore;

class AudioFrame;

-template<typename T>

-class Beamformer;

+class NonlinearBeamformer;

class StreamConfig;

class ProcessingConfig;

@@ -269,7 +268,7 @@ class AudioProcessing {

static AudioProcessing* Create(const Config& config);

// Only for testing.

static AudioProcessing* Create(const Config& config,

- Beamformer<float>* beamformer);

+ NonlinearBeamformer* beamformer);

virtual ~AudioProcessing() {}

// Initializes internal states, while retaining all user settings. This