webrtc/modules/audio_processing/audio_processing_impl.h - Issue 1982183002: Pull out the PostFilter to its own NonlinearBeamformer API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.h

Issue 1982183002: Pull out the PostFilter to its own NonlinearBeamformer API (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Drop Beamformer Interface Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_audio/channel_buffer.h ('K') | « webrtc/modules/audio_processing/audio_processing.gypi ('k') | webrtc/modules/audio_processing/audio_processing_impl.cc » ('j') | webrtc/modules/audio_processing/audio_processing_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/audio_processing_impl.h

diff --git a/webrtc/modules/audio_processing/audio_processing_impl.h b/webrtc/modules/audio_processing/audio_processing_impl.h

index 7323b85c78eccd03d26bae2ac49e9f67eda4f903..be4f7f021d8dfb457c3aef7a2008b532720838d9 100644

--- a/webrtc/modules/audio_processing/audio_processing_impl.h

+++ b/webrtc/modules/audio_processing/audio_processing_impl.h

@@ -36,8 +36,7 @@ namespace webrtc {

class AgcManagerDirect;

class AudioConverter;

-template<typename T>

-class Beamformer;

+class NonlinearBeamformer;

class AudioProcessingImpl : public AudioProcessing {

public:

@@ -45,7 +44,7 @@ class AudioProcessingImpl : public AudioProcessing {

// Acquires both the render and capture locks.

explicit AudioProcessingImpl(const Config& config);

// AudioProcessingImpl takes ownership of beamformer.

- AudioProcessingImpl(const Config& config, Beamformer<float>* beamformer);

+ AudioProcessingImpl(const Config& config, NonlinearBeamformer* beamformer);

virtual ~AudioProcessingImpl();

int Initialize() override;

int Initialize(int input_sample_rate_hz,