Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 1981573002: Revert of New task queueing primitive for async tasks: TaskQueue. (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
Reviewers:
phoglund, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of New task queueing primitive for async tasks: TaskQueue. (patchset #8 id:330001 of https://codereview.webrtc.org/1927133004/ ) Reason for revert: sigh. Have to revert again as there seems to have have been some change made for pnacl and CrOS. Original issue's description: > Reland of New task queueing primitive for async tasks: TaskQueue. (patchset #1 id:1 of https://codereview.webrtc.org/1935483002/ ) > > New task queueing primitive for async tasks: TaskQueue. > TaskQueue is a new way to asynchronously execute tasks sequentially > in a thread safe manner with minimal locking. The implementation > uses OS supported APIs to do this that are compatible with async IO > notifications from things like sockets and files. > > This class is a part of rtc_base_approved, so can be used by both > the webrtc and libjingle parts of the WebRTC library. Moving forward, > we can replace rtc::Thread and webrtc::ProcessThread with this implementation. > > NOTE: It should not be assumed that all tasks that execute on a TaskQueue, > run on the same thread. E.g. on Mac and iOS, we use GCD dispatch queues > which means that tasks might execute on different threads depending on > what's the most efficient thing to do. > > TBR=perkj@webrtc.org > > Committed: https://crrev.com/65d1f2aba216d077c6d22488f03e56984aef1c68 > Cr-Commit-Position: refs/heads/master@{#12737} TBR=perkj@webrtc.org,phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3f90087ce8dccd0005a6c1589d34ef98486775f1 Cr-Commit-Position: refs/heads/master@{#12738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1337 lines) Patch
M webrtc/base/BUILD.gn View 3 chunks +0 lines, -20 lines 0 comments Download
M webrtc/base/base.gyp View 2 chunks +0 lines, -19 lines 0 comments Download
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/base/task_queue.h View 1 chunk +0 lines, -277 lines 0 comments Download
D webrtc/base/task_queue_gcd.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D webrtc/base/task_queue_libevent.cc View 1 chunk +0 lines, -318 lines 0 comments Download
D webrtc/base/task_queue_posix.h View 1 chunk +0 lines, -36 lines 0 comments Download
D webrtc/base/task_queue_posix.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/base/task_queue_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D webrtc/base/task_queue_win.cc View 1 chunk +0 lines, -184 lines 0 comments Download
M webrtc/build/common.gypi View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tommi
Created Revert of New task queueing primitive for async tasks: TaskQueue.
4 years, 7 months ago (2016-05-13 21:33:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981573002/1
4 years, 7 months ago (2016-05-13 21:33:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 21:33:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3f90087ce8dccd0005a6c1589d34ef98486775f1 Cr-Commit-Position: refs/heads/master@{#12738}
4 years, 7 months ago (2016-05-13 21:33:48 UTC) #5
tommi
4 years, 7 months ago (2016-05-14 13:00:22 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1984503002/ by tommi@webrtc.org.

The reason for reverting is: Reland of New task queueing primitive for async
tasks: TaskQueue..

Powered by Google App Engine
This is Rietveld 408576698