Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: webrtc/base/base.gyp

Issue 1980003002: Separate building and enabling libevent. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/base.gyp
diff --git a/webrtc/base/base.gyp b/webrtc/base/base.gyp
index 4564504aabf01390c1a12829b73a7145b53f0744..c0e92d94685b70ccdeba41ae006827d9f23f6b3a 100644
--- a/webrtc/base/base.gyp
+++ b/webrtc/base/base.gyp
@@ -121,7 +121,8 @@
'dependencies': [
'<(DEPTH)/base/third_party/libevent/libevent.gyp:libevent',
],
- }, {
+ }],
+ ['enable_libevent!=1', {
kjellander_webrtc 2016/05/16 12:21:13 I suggest starting with enable_libevent==1 and t
phoglund 2016/05/16 13:18:01 Yeah, I might as well do it here so I'll do it.
'sources!': [ 'task_queue_libevent.cc' ],
'conditions': [
['OS=="linux" or OS=="android"', {
@@ -129,7 +130,7 @@
}],
],
}],
- ['build_libevent==1 or OS=="linux" or OS=="android" or OS=="win"', {
+ ['enable_libevent==1 or OS=="linux" or OS=="android" or OS=="win"', {
kjellander_webrtc 2016/05/16 12:21:13 See previous comment. You can put this into a sub-
phoglund 2016/05/16 13:18:01 Done.
'sources!': [ 'task_queue_gcd.cc' ],
}],
['OS=="mac" and build_with_chromium==0', {
« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698