webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c - Issue 1979973003: Fix UBSan errors (left shift of negative value, left shift overflows int)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

Issue 1979973003: Fix UBSan errors (left shift of negative value, left shift overflows int) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: variable name Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c b/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

index 63e4928bd8814e5e48ce2050d42d3888851bdb74..47bbe31b8ae4d9e898cfabea845adb7ffb912fcc 100644

--- a/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

+++ b/webrtc/modules/audio_coding/codecs/isac/main/source/arith_routines_hist.c

@@ -214,10 +214,10 @@ int WebRtcIsac_DecHistOneStepMulti(int *data, /* output: data vector */

if (streamdata->stream_index == 0) /* first time decoder is called for this stream */

{

/* read first word from bytestream */

- streamval = *stream_ptr << 24;

- streamval |= *++stream_ptr << 16;

- streamval |= *++stream_ptr << 8;

- streamval |= *++stream_ptr;

+ streamval = (uint32_t)(*stream_ptr) << 24;

+ streamval |= (uint32_t)(*++stream_ptr) << 16;

+ streamval |= (uint32_t)(*++stream_ptr) << 8;

+ streamval |= (uint32_t)(*++stream_ptr);

} else {

streamval = streamdata->streamval;

}

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/isac/main/source/entropy_coding.c » ('j') | no next file with comments »