Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1979933002: Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in preparation for removing src/third_party/libjingle in Chromium. Changes from previous attempt: * Added libstunprober target * Adjusted warnings for Chromium's clang plugins * webrtc/pc/externalhmac.{h,cc} added for Chromium builds. As soon this has landed a roll including the changes in https://codereview.chromium.org/2022833002/ is needed to make Chromium build cleanly. BUG=webrtc:4256 NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/164e978f981c7810c4260c4184f41e26bae90230 Cr-Commit-Position: refs/heads/master@{#12983}

Patch Set 1 : Pristine revert CL #

Patch Set 2 : Added libstunprober target #

Patch Set 3 : Rebased #

Patch Set 4 : Rebase and adjustments to pass GN check #

Patch Set 5 : Add externalhmac.{h,cc} files for Chromium build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+776 lines, -17 lines) Patch
M webrtc/BUILD.gn View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +127 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
A + webrtc/libjingle/xmllite/BUILD.gn View 1 2 3 2 chunks +31 lines, -17 lines 0 comments Download
A webrtc/libjingle/xmpp/BUILD.gn View 1 2 3 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/media/BUILD.gn View 1 chunk +206 lines, -0 lines 0 comments Download
A webrtc/p2p/BUILD.gn View 1 2 3 1 chunk +155 lines, -0 lines 0 comments Download
A webrtc/pc/BUILD.gn View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
perkj_webrtc
lgtm
4 years, 7 months ago (2016-05-16 06:07:00 UTC) #1
kjellander_webrtc
On 2016/05/16 06:07:00, perkj_webrtc wrote: > lgtm This CL will break our Chromium FYI bots ...
4 years, 7 months ago (2016-05-16 07:09:02 UTC) #2
kjellander_webrtc
See trybot results for PS#2. Unfortunately running Chromium tryjobs is pointless since https://codereview.chromium.org/2022833002/ is also ...
4 years, 6 months ago (2016-05-31 11:54:09 UTC) #6
tommi
lgtm
4 years, 6 months ago (2016-05-31 13:28:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979933002/80001
4 years, 6 months ago (2016-06-01 09:13:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5994)
4 years, 6 months ago (2016-06-01 09:16:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979933002/80001
4 years, 6 months ago (2016-06-01 09:17:44 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-01 09:17:55 UTC) #18
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/164e978f981c7810c4260c4184f41e26bae90230 Cr-Commit-Position: refs/heads/master@{#12983}
4 years, 6 months ago (2016-06-01 09:18:02 UTC) #20
kjellander_webrtc
4 years, 6 months ago (2016-06-01 11:44:50 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2023233002/ by kjellander@webrtc.org.

The reason for reverting is: Too many errors to address showed up when trying to
land this with Chromium changes in https://codereview.chromium.org/2022833002/.
Will address them separately before relanding..

Powered by Google App Engine
This is Rietveld 408576698