Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1979463003: Revert of Allow the localhost IP address even if it does not match the tcp port address (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Allow the localhost IP address even if it does not match the tcp port address (patchset #4 id:120001 of https://codereview.webrtc.org/1914803002/ ) Reason for revert: Speculatively reverting due to failures on the memcheck bot (and possibly other bots): https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/5910/steps/video_engine_tests/logs/EndToEndTest.SendsAndReceivesH264 Original issue's description: > This fixes an issue similar to > https://bugs.chromium.org/p/webrtc/issues/detail?id=3927 > where the localhost IP does not match the turn port address. > The issue here is in the TCP port. > > BUG= > R=pthatcher@webrtc.org > > Committed: https://crrev.com/6705012904e6cbbefce6fbce0a3f615b7aeafd8f > Cr-Commit-Position: refs/heads/master@{#12707} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,honghaiz@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1cbf0a73eb4b475e8beb878ea3a4d650191f0c08 Cr-Commit-Position: refs/heads/master@{#12728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -116 lines) Patch
M webrtc/base/virtualsocketserver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/virtualsocketserver.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/p2p/base/tcpport.cc View 1 chunk +17 lines, -24 lines 0 comments Download
D webrtc/p2p/base/tcpport_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tommi
Created Revert of Allow the localhost IP address even if it does not match the ...
4 years, 7 months ago (2016-05-13 14:39:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979463003/1
4 years, 7 months ago (2016-05-13 14:39:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 14:39:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1cbf0a73eb4b475e8beb878ea3a4d650191f0c08 Cr-Commit-Position: refs/heads/master@{#12728}
4 years, 7 months ago (2016-05-13 14:39:56 UTC) #6
tommi
4 years, 7 months ago (2016-05-14 10:19:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1979073002/ by tommi@webrtc.org.

The reason for reverting is: Relanding this change since the revert didn't make
a difference..

Powered by Google App Engine
This is Rietveld 408576698