Add H264 bitstream rewriting to limit frame reordering marker in header

webrtc/modules/rtp_rtcp/source/h264/pps_parser.h

+/*
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_H264_PPS_PARSER_H_
+#define WEBRTC_MODULES_RTP_RTCP_SOURCE_H264_PPS_PARSER_H_
+
+#include "webrtc/base/common.h"
+#include "webrtc/base/optional.h"
+
+namespace webrtc {
+
+// A class for parsing out picture parameter set (PPS) data from a H264 NALU.
+class PpsParser {
+ public:
+  PpsParser(const uint8_t* buffer, size_t buffer_length);
+
+  // Parses the PPS to completion. Returns true if the SPS was parsed correctly.
+  bool Parse();

[noahric, 2016/05/18 01:35:07]

I know this is unrelated, but this class would be cleaner as a single static
method (Parse) that returned a bool and had an out parameter for state.

[sprang_webrtc, 2016/05/20 16:11:00]

Acknowledged.

+
+  // The parsed state of the PPS. Only some select values are stored.
+  // Add more as they are actually needed.
+  struct PpsState {
+    PpsState() = default;
+
+    bool bottom_field_pic_order_in_frame_present_flag = false;
+    bool weighted_pred_flag = false;
+    uint32_t weighted_bipred_idc = false;
+    uint32_t redundant_pic_cnt_present_flag = 0;
+    int pic_init_qp_minus26 = 0;
+  };
+
+  // Get the parsed PPS state.
+  const rtc::Optional<PpsState>& GetState() const;
+
+ private:
+  const uint8_t* const buffer_;
+  const size_t buffer_length_;
+  rtc::Optional<PpsState> state_;
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_RTP_RTCP_SOURCE_H264_PPS_PARSER_H_