Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1978783002: Revert of Remove ViEEncoder::SetNetworkStatus (Closed)

Created:
4 years, 7 months ago by perkj_webrtc
Modified:
4 years, 7 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@move_pacer
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove ViEEncoder::SetNetworkStatus (patchset #11 id:200001 of https://codereview.webrtc.org/1932683002/ ) Reason for revert: Breaks Chrome FYI using H264. Need to investigate. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/4170 Original issue's description: > Remove ViEEncoder::SetNetworkStatus > > This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will report that frames can not be sent when the network is down and the BitrateController will report an estimated available bandwidth of 0 bps. > > BUG=webrtc:5687 > NOTRY=True > > Committed: https://crrev.com/50b5c3be844ef571a28b2681c549443a26735d72 > Cr-Commit-Position: refs/heads/master@{#12699} TBR=stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/7339c500fe5dec689e69a6cfc745f2508cbcdedf Cr-Commit-Position: refs/heads/master@{#12715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -103 lines) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 5 chunks +14 lines, -44 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 2 chunks +4 lines, -9 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perkj_webrtc
Created Revert of Remove ViEEncoder::SetNetworkStatus
4 years, 7 months ago (2016-05-13 08:17:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978783002/1
4 years, 7 months ago (2016-05-13 08:17:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 08:17:34 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 08:17:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7339c500fe5dec689e69a6cfc745f2508cbcdedf
Cr-Commit-Position: refs/heads/master@{#12715}

Powered by Google App Engine
This is Rietveld 408576698