Disable libyuv jpeg support on Android

Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.

Also, remove unused build_libjpeg and rtc_build_libjpeg variables.

Committed: https://crrev.com/de8739c120afaf43c7642d2bfd8fc8ec3fc9abe9
Cr-Commit-Position: refs/heads/master@{#12777}

[magjed_webrtc, 2016-05-16 13:38:57]

Description was changed from

==========
Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.
==========

to

==========
Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.

Also, remove unused build_libjpeg and rtc_build_libjpeg variables.
==========

[magjed_webrtc, 2016-05-16 13:39:21]

magjed@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[magjed_webrtc, 2016-05-16 13:39:35]

kjellander - Please take a look.

[kjellander_webrtc, 2016-05-16 14:23:22]

https://codereview.webrtc.org/1978243002/diff/1/webrtc/supplement.gypi
File webrtc/supplement.gypi (right):

https://codereview.webrtc.org/1978243002/diff/1/webrtc/supplement.gypi#newcode30
webrtc/supplement.gypi:30: 'libyuv_disable_jpeg%': 1,
You only need to put a variable in supplement.gypi if you're going to override a
default value in Chromium's build/common.gypi.

For this case, store it in webrtc/build/common.gypi instead, since it's only
read in https://chromium.googlesource.com/libyuv/libyuv/+/master/libyuv.gyp#21

That said, it looks like we need to introduce the variable in GN as well, but
it's not important to do now since the builds we're targeting with this
optimization are based on GYP.

[magjed_webrtc, 2016-05-17 08:45:57]

https://codereview.webrtc.org/1978243002/diff/1/webrtc/supplement.gypi
File webrtc/supplement.gypi (right):

https://codereview.webrtc.org/1978243002/diff/1/webrtc/supplement.gypi#newcode30
webrtc/supplement.gypi:30: 'libyuv_disable_jpeg%': 1,
On 2016/05/16 14:23:22, kjellander (webrtc) wrote:
> You only need to put a variable in supplement.gypi if you're going to override
a
> default value in Chromium's build/common.gypi.
> 
> For this case, store it in webrtc/build/common.gypi instead, since it's only
> read in https://chromium.googlesource.com/libyuv/libyuv/+/master/libyuv.gyp#21
I tried moving it to webrtc/build/common.gypi, but then libjpeg_turbo got
included in libjingle_peerconnection_so again, so it doesn't work. I don't know
how the include order works for these files, but I guess libyuv.gyp is included
before webrtc/build/common.gypi.

[kjellander_webrtc, 2016-05-17 14:07:49]

lgtm

https://codereview.webrtc.org/1978243002/diff/1/webrtc/supplement.gypi
File webrtc/supplement.gypi (right):

https://codereview.webrtc.org/1978243002/diff/1/webrtc/supplement.gypi#newcode30
webrtc/supplement.gypi:30: 'libyuv_disable_jpeg%': 1,
On 2016/05/17 08:45:56, magjed_webrtc wrote:
> On 2016/05/16 14:23:22, kjellander (webrtc) wrote:
> > You only need to put a variable in supplement.gypi if you're going to
override
> a
> > default value in Chromium's build/common.gypi.
> > 
> > For this case, store it in webrtc/build/common.gypi instead, since it's only
> > read in
https://chromium.googlesource.com/libyuv/libyuv/+/master/libyuv.gyp#21
> I tried moving it to webrtc/build/common.gypi, but then libjpeg_turbo got
> included in libjingle_peerconnection_so again, so it doesn't work. I don't
know
> how the include order works for these files, but I guess libyuv.gyp is
included
> before webrtc/build/common.gypi.

Oh dear, GYP trickery. We chatted offline and came to the conclusion that this
must be because libyuv.gyp doesn't include our webrtc/build/common.gypi, so it
probably gets its own environment of GYP variables. If that's how it works, we
need to set this in the global GYP scope, which means this actually is the right
place!

[magjed_webrtc, 2016-05-17 14:26:39]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-05-17 14:26:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978243002/1

[commit-bot: I haz the power, 2016-05-17 15:39:14]

Description was changed from

==========
Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.

Also, remove unused build_libjpeg and rtc_build_libjpeg variables.
==========

to

==========
Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.

Also, remove unused build_libjpeg and rtc_build_libjpeg variables.
==========

[commit-bot: I haz the power, 2016-05-17 15:39:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 15:39:23]

Description was changed from

==========
Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.

Also, remove unused build_libjpeg and rtc_build_libjpeg variables.
==========

to

==========
Disable libyuv jpeg support on Android

MJPEG capture is not used on Android. Therefore, disable jpeg support to
reduce libjingle_peerconnection_so file size by removing dependency to
libjpeg_turbo.

Also, remove unused build_libjpeg and rtc_build_libjpeg variables.

Committed: https://crrev.com/de8739c120afaf43c7642d2bfd8fc8ec3fc9abe9
Cr-Commit-Position: refs/heads/master@{#12777}
==========

[commit-bot: I haz the power, 2016-05-17 15:39:24]

Patchset 1 (id:??) landed as
https://crrev.com/de8739c120afaf43c7642d2bfd8fc8ec3fc9abe9
Cr-Commit-Position: refs/heads/master@{#12777}