webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h - Issue 1978233002: Polishing code to handle certificate generation failure in .mm files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h

Issue 1978233002: Polishing code to handle certificate generation failure in .mm files. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm ('k') | webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm » ('j') | webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h

diff --git a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h

index 4c020f9588dd92b374af5bd17b90f0d54b9e9d37..aec3c6607e2d89f97990a13031305edae1aedcbd 100644

--- a/webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h

+++ b/webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h

@@ -20,8 +20,8 @@ NS_ASSUME_NONNULL_BEGIN

* RTCConfiguration struct representation of this RTCConfiguration. This is

* needed to pass to the underlying C++ APIs.

-@property(nonatomic, readonly)

- webrtc::PeerConnectionInterface::RTCConfiguration* nativeConfiguration;

+- (webrtc::PeerConnectionInterface::RTCConfiguration *)

+ createNativeConfiguration;

tkchin_webrtc 2016/05/16 21:01:32 nit: instance methods below static ones (so place

hbos 2016/05/17 09:05:03 Done.

+ (webrtc::PeerConnectionInterface::IceTransportsType)

nativeTransportsTypeForTransportPolicy:(RTCIceTransportPolicy)policy;