Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1976913002: Add muted_output parameter to ACM (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add muted_output parameter to ACM The new parameter indicates if the output in the AudioFrame is muted. If so, the output samples are not written, but should be interpreted as all zero. A version of AudioCodingModule::PlayoutData10Ms() without the new parameter is maintained while waiting for downstream dependencies to conform. BUG=webrtc:5609 Committed: https://crrev.com/834a6ea12bcd65e79c39a8a5cb5e1cd9e13b2ca0 Cr-Commit-Position: refs/heads/master@{#12719}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -16 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 5 chunks +15 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 2 chunks +11 lines, -2 lines 2 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
hlundin-webrtc
PTAL. Thanks!
4 years, 7 months ago (2016-05-13 09:32:23 UTC) #2
minyue-webrtc
lgtm https://codereview.webrtc.org/1976913002/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc File webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc (right): https://codereview.webrtc.org/1976913002/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc#newcode810 webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc:810: RTC_DCHECK(!muted); Is it possible to check enable_fast_accelerate of ...
4 years, 7 months ago (2016-05-13 09:43:12 UTC) #3
hlundin-webrtc
https://codereview.webrtc.org/1976913002/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc File webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc (right): https://codereview.webrtc.org/1976913002/diff/1/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc#newcode810 webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc:810: RTC_DCHECK(!muted); On 2016/05/13 09:43:12, minyue-webrtc wrote: > Is it ...
4 years, 7 months ago (2016-05-13 09:45:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976913002/1
4 years, 7 months ago (2016-05-13 09:46:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 10:45:28 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 10:45:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/834a6ea12bcd65e79c39a8a5cb5e1cd9e13b2ca0
Cr-Commit-Position: refs/heads/master@{#12719}

Powered by Google App Engine
This is Rietveld 408576698