UBSan: Suppress openh264 and NetEq errors.

UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error: shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Committed: https://crrev.com/27178676cfaf72c17b282a366a1ca190c383757e
Cr-Commit-Position: refs/heads/master@{#12706}

[kjellander_webrtc, 2016-05-12 15:39:04]

Description was changed from

==========
UBSan: Suppress openh264 errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan error:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
Suppress such errors since this source code is out of our control.
==========

to

==========
UBSan: Suppress openh264 errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan error:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
Suppress such errors since this source code is out of our control.
==========

[kjellander_webrtc, 2016-05-12 15:39:04]

kjellander@webrtc.org changed reviewers:
+ hbos@webrtc.org

[kjellander_webrtc, 2016-05-12 15:39:42]

I discovered this in https://codereview.webrtc.org/1969133002 so we need to
suppress this before we can turn on rtc_use_h264=1 on the bots.
All other tests seems to pass now.

[kjellander_webrtc, 2016-05-12 16:05:18]

On 2016/05/12 15:39:42, kjellander (webrtc) wrote:
> I discovered this in https://codereview.webrtc.org/1969133002 so we need to
> suppress this before we can turn on rtc_use_h264=1 on the bots.
> All other tests seems to pass now.

Hold on, more suppressions are needed.

[kjellander_webrtc, 2016-05-12 16:06:04]

Description was changed from

==========
UBSan: Suppress openh264 errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan error:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
Suppress such errors since this source code is out of our control.
==========

to

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan error:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
==========

[kjellander_webrtc, 2016-05-12 16:09:21]

Description was changed from

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan error:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
==========

to

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')

third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'

Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
==========

[kjellander_webrtc, 2016-05-12 16:09:33]

Description was changed from

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')

third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'

Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
==========

to

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
==========

[kjellander_webrtc, 2016-05-12 16:23:39]

Description was changed from

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
==========

to

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org
==========

[kjellander_webrtc, 2016-05-12 16:24:05]

On 2016/05/12 16:05:18, kjellander (webrtc) wrote:
> On 2016/05/12 15:39:42, kjellander (webrtc) wrote:
> > I discovered this in https://codereview.webrtc.org/1969133002 so we need to
> > suppress this before we can turn on rtc_use_h264=1 on the bots.
> > All other tests seems to pass now.
> 
> Hold on, more suppressions are needed.

TBRing since this is a safe change and cannot possibly break anything - and I
can finally turn this thing on at the bots.

[kjellander_webrtc, 2016-05-12 16:24:45]

Description was changed from

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org
==========

to

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/27178676cfaf72c17b282a366...
==========

[kjellander_webrtc, 2016-05-12 16:24:47]

Committed patchset #2 (id:20001) manually as
27178676cfaf72c17b282a366a1ca190c383757e (presubmit successful).

[commit-bot: I haz the power, 2016-05-12 16:24:50]

Description was changed from

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/27178676cfaf72c17b282a366...
==========

to

==========
UBSan: Suppress openh264 and NetEq errors.

As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error:
shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out
of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Committed: https://crrev.com/27178676cfaf72c17b282a366a1ca190c383757e
Cr-Commit-Position: refs/heads/master@{#12706}
==========

[kjellander_webrtc, 2016-05-12 16:24:51]

On 2016/05/12 16:24:05, kjellander (webrtc) wrote:
> On 2016/05/12 16:05:18, kjellander (webrtc) wrote:
> > On 2016/05/12 15:39:42, kjellander (webrtc) wrote:
> > > I discovered this in https://codereview.webrtc.org/1969133002 so we need
to
> > > suppress this before we can turn on rtc_use_h264=1 on the bots.
> > > All other tests seems to pass now.
> > 
> > Hold on, more suppressions are needed.
> 
> TBRing since this is a safe change and cannot possibly break anything - and I
> can finally turn this thing on at the bots.

(https://codereview.webrtc.org/1969133002/ went green, which contains the same
change + enabling H264).

[hbos, 2016-05-13 07:12:10]

hbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[hbos, 2016-05-13 07:12:11]

+pbos, FYI

[pbos-webrtc, 2016-05-14 00:48:51]

+cc henrik.lundin@/kwiberg@ for the NetEq suppression.

[kjellander_webrtc, 2016-05-15 19:19:32]

On 2016/05/14 00:48:51, pbos-webrtc wrote:
> +cc henrik.lundin@/kwiberg@ for the NetEq suppression.

Thanks (I already assigned the bug to henrik.lundin@)