Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1975743002: Fixes a bug where AppRTC Android Demo crashes with empty roomId. (Closed)

Created:
4 years, 7 months ago by sakal
Modified:
4 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixes a bug where AppRTC Android Demo crashes with empty roomId. BUG= R=magjed@webrtc.org Committed: https://crrev.com/970567cab2fd74646eb5fedd1f49b1e8f1e30fca Cr-Commit-Position: refs/heads/master@{#12759}

Patch Set 1 #

Patch Set 2 : Styling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 1 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
sakal
On 2016/05/16 11:20:33, sakal wrote: > mailto:sakal@webrtc.org changed reviewers: > + mailto:magjed@webrtc.org I tried to ...
4 years, 7 months ago (2016-05-16 11:22:16 UTC) #5
magjed_webrtc
lgtm
4 years, 7 months ago (2016-05-16 12:06:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975743002/20001
4 years, 7 months ago (2016-05-16 12:16:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/15140)
4 years, 7 months ago (2016-05-16 12:40:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975743002/20001
4 years, 7 months ago (2016-05-16 13:01:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-16 14:17:13 UTC) #14
sakal
4 years, 7 months ago (2016-05-16 14:24:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
970567cab2fd74646eb5fedd1f49b1e8f1e30fca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698