Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: webrtc/api/peerconnectioninterface_unittest.cc

Issue 1975453002: Add PeerConnection IsClosed check. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Modified the checks. Modified the peerconnectioninterface unit test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/peerconnection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface_unittest.cc
diff --git a/webrtc/api/peerconnectioninterface_unittest.cc b/webrtc/api/peerconnectioninterface_unittest.cc
index 2594b6c10637996c3a554757a188da633d5b12cb..27db22cd12d6502b9b75ce93de48b218bb419f26 100644
--- a/webrtc/api/peerconnectioninterface_unittest.cc
+++ b/webrtc/api/peerconnectioninterface_unittest.cc
@@ -702,7 +702,9 @@ class PeerConnectionInterfaceTest : public testing::Test {
} else {
pc_->SetRemoteDescription(observer, desc);
}
- EXPECT_EQ_WAIT(true, observer->called(), kTimeout);
+ if (pc_->signaling_state() != PeerConnectionInterface::kClosed) {
+ EXPECT_EQ_WAIT(true, observer->called(), kTimeout);
+ }
pthatcher1 2016/05/12 05:44:13 Shouldn't we add some unit tests to verify the beh
return observer->result();
}
« no previous file with comments | « webrtc/api/peerconnection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698