Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1975223002: Revert of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (patchset #2 id:20001 of https://codereview.webrtc.org/1973313002/ ) Reason for revert: Breaks GN in Chromium (again), even though I tested this configuration: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/6000/steps/generate_build_files/logs/stdio Original issue's description: > Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} > > Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in > preparation for removing src/third_party/libjingle in Chromium. > > BUG=webrtc:4256 > NOTRY=True > TBR=perkj@webrtc.org > > Committed: https://crrev.com/c8d848b1049d8b9e8e33e023d13bec1180dd4926 > Cr-Commit-Position: refs/heads/master@{#12731} TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Committed: https://crrev.com/fb1dd43ac137e50c0c26e97f5e9866135da24e2c Cr-Commit-Position: refs/heads/master@{#12733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -769 lines) Patch
M webrtc/BUILD.gn View 3 chunks +0 lines, -8 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +0 lines, -127 lines 0 comments Download
M webrtc/build/webrtc.gni View 3 chunks +0 lines, -12 lines 0 comments Download
D webrtc/libjingle/xmllite/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +0 lines, -154 lines 0 comments Download
D webrtc/media/BUILD.gn View 1 chunk +0 lines, -206 lines 0 comments Download
D webrtc/p2p/BUILD.gn View 1 chunk +0 lines, -138 lines 0 comments Download
D webrtc/pc/BUILD.gn View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
Created Revert of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc}
4 years, 7 months ago (2016-05-13 17:28:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975223002/1
4 years, 7 months ago (2016-05-13 17:28:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 17:28:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb1dd43ac137e50c0c26e97f5e9866135da24e2c Cr-Commit-Position: refs/heads/master@{#12733}
4 years, 7 months ago (2016-05-13 17:29:07 UTC) #5
kjellander_webrtc
4 years, 7 months ago (2016-05-16 06:13:52 UTC) #6
Message was sent while issue was closed.
On 2016/05/13 17:29:07, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/fb1dd43ac137e50c0c26e97f5e9866135da24e2c
> Cr-Commit-Position: refs/heads/master@{#12733}

(the reason this wasn't caught with my local test was that I wasn't running with
--check, which is default enabled in Chromium but not possible to have enabled
in WebRTC yet).

Powered by Google App Engine
This is Rietveld 408576698