webrtc/api/java/jni/peerconnection_jni.cc - Issue 1973873003: Delete AndroidVideoCapturer::FrameFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/jni/peerconnection_jni.cc

Issue 1973873003: Delete AndroidVideoCapturer::FrameFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Move code to AndroidVideoCapturerJni. Make Matrix a class. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/java/jni/peerconnection_jni.cc

diff --git a/webrtc/api/java/jni/peerconnection_jni.cc b/webrtc/api/java/jni/peerconnection_jni.cc

index 09e8db24e791f31e566d13f6a3650791b14ac342..06e188c121e9f22415e8aa53699be3443d6dc0f2 100644

--- a/webrtc/api/java/jni/peerconnection_jni.cc

+++ b/webrtc/api/java/jni/peerconnection_jni.cc

@@ -794,8 +794,8 @@ class JavaVideoRendererWrapper

jobject CricketToJavaTextureFrame(const cricket::VideoFrame* frame) {

NativeHandleImpl* handle =

reinterpret_cast<NativeHandleImpl*>(frame->GetNativeHandle());

- jfloatArray sampling_matrix = jni()->NewFloatArray(16);

- jni()->SetFloatArrayRegion(sampling_matrix, 0, 16, handle->sampling_matrix);

+ jfloatArray sampling_matrix = handle->sampling_matrix.ToJava(jni());

return jni()->NewObject(

*j_frame_class_, j_texture_frame_ctor_id_,

frame->width(), frame->height(),