Chromium Code Reviews

Issue 1973293003: Use generic CPU-overuse thresholds for iOS. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi, juberti2
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use generic CPU-overuse thresholds for iOS. Prevents overly-aggressive CPU adaptation on iOS where input frames get downscaled after ~40% CPU usage. BUG= R=tommi@webrtc.org Committed: https://crrev.com/a1025073a9f92ab3471f669fa0c5d586f2440d6b Cr-Commit-Position: refs/heads/master@{#12744}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -4 lines)
M webrtc/video/overuse_frame_detector.cc View 3 chunks +4 lines, -4 lines 0 comments

Messages

Total messages: 14 (5 generated)
pbos-webrtc
PTAL
4 years, 7 months ago (2016-05-14 00:14:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973293003/1
4 years, 7 months ago (2016-05-14 00:14:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-14 01:14:47 UTC) #5
juberti2
lgtm TBH, I think this 'experimental' code is of dubious value. It's a fairly blunt ...
4 years, 7 months ago (2016-05-14 05:58:44 UTC) #7
juberti2
On 2016/05/14 05:58:44, juberti2 wrote: > lgtm > > TBH, I think this 'experimental' code ...
4 years, 7 months ago (2016-05-14 05:59:19 UTC) #8
tommi
lgtm
4 years, 7 months ago (2016-05-14 09:58:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973293003/1
4 years, 7 months ago (2016-05-14 09:58:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-14 10:04:24 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 10:04:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1025073a9f92ab3471f669fa0c5d586f2440d6b
Cr-Commit-Position: refs/heads/master@{#12744}

Powered by Google App Engine