Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: webrtc/pc/channelmanager.h

Issue 1972493002: Do not create a temporary transport channel when using max-bundle (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/channel_unittest.cc ('k') | webrtc/pc/channelmanager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 bool Init(); 84 bool Init();
85 // Shuts down the media engine. 85 // Shuts down the media engine.
86 void Terminate(); 86 void Terminate();
87 87
88 // The operations below all occur on the worker thread. 88 // The operations below all occur on the worker thread.
89 // Creates a voice channel, to be associated with the specified session. 89 // Creates a voice channel, to be associated with the specified session.
90 VoiceChannel* CreateVoiceChannel( 90 VoiceChannel* CreateVoiceChannel(
91 webrtc::MediaControllerInterface* media_controller, 91 webrtc::MediaControllerInterface* media_controller,
92 TransportController* transport_controller, 92 TransportController* transport_controller,
93 const std::string& content_name, 93 const std::string& content_name,
94 const std::string* bundle_transport_name,
94 bool rtcp, 95 bool rtcp,
95 const AudioOptions& options); 96 const AudioOptions& options);
96 // Destroys a voice channel created with the Create API. 97 // Destroys a voice channel created with the Create API.
97 void DestroyVoiceChannel(VoiceChannel* voice_channel); 98 void DestroyVoiceChannel(VoiceChannel* voice_channel);
98 // Creates a video channel, synced with the specified voice channel, and 99 // Creates a video channel, synced with the specified voice channel, and
99 // associated with the specified session. 100 // associated with the specified session.
100 VideoChannel* CreateVideoChannel( 101 VideoChannel* CreateVideoChannel(
101 webrtc::MediaControllerInterface* media_controller, 102 webrtc::MediaControllerInterface* media_controller,
102 TransportController* transport_controller, 103 TransportController* transport_controller,
103 const std::string& content_name, 104 const std::string& content_name,
105 const std::string* bundle_transport_name,
104 bool rtcp, 106 bool rtcp,
105 const VideoOptions& options); 107 const VideoOptions& options);
106 // Destroys a video channel created with the Create API. 108 // Destroys a video channel created with the Create API.
107 void DestroyVideoChannel(VideoChannel* video_channel); 109 void DestroyVideoChannel(VideoChannel* video_channel);
108 DataChannel* CreateDataChannel(TransportController* transport_controller, 110 DataChannel* CreateDataChannel(TransportController* transport_controller,
109 const std::string& content_name, 111 const std::string& content_name,
112 const std::string* bundle_transport_name,
110 bool rtcp, 113 bool rtcp,
111 DataChannelType data_channel_type); 114 DataChannelType data_channel_type);
112 // Destroys a data channel created with the Create API. 115 // Destroys a data channel created with the Create API.
113 void DestroyDataChannel(DataChannel* data_channel); 116 void DestroyDataChannel(DataChannel* data_channel);
114 117
115 // Indicates whether any channels exist. 118 // Indicates whether any channels exist.
116 bool has_channels() const { 119 bool has_channels() const {
117 return (!voice_channels_.empty() || !video_channels_.empty()); 120 return (!voice_channels_.empty() || !video_channels_.empty());
118 } 121 }
119 122
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 DataEngineInterface* dme, 154 DataEngineInterface* dme,
152 rtc::Thread* worker_thread, 155 rtc::Thread* worker_thread,
153 rtc::Thread* network_thread); 156 rtc::Thread* network_thread);
154 bool InitMediaEngine_w(); 157 bool InitMediaEngine_w();
155 void DestructorDeletes_w(); 158 void DestructorDeletes_w();
156 void Terminate_w(); 159 void Terminate_w();
157 VoiceChannel* CreateVoiceChannel_w( 160 VoiceChannel* CreateVoiceChannel_w(
158 webrtc::MediaControllerInterface* media_controller, 161 webrtc::MediaControllerInterface* media_controller,
159 TransportController* transport_controller, 162 TransportController* transport_controller,
160 const std::string& content_name, 163 const std::string& content_name,
164 const std::string* bundle_transport_name,
161 bool rtcp, 165 bool rtcp,
162 const AudioOptions& options); 166 const AudioOptions& options);
163 void DestroyVoiceChannel_w(VoiceChannel* voice_channel); 167 void DestroyVoiceChannel_w(VoiceChannel* voice_channel);
164 VideoChannel* CreateVideoChannel_w( 168 VideoChannel* CreateVideoChannel_w(
165 webrtc::MediaControllerInterface* media_controller, 169 webrtc::MediaControllerInterface* media_controller,
166 TransportController* transport_controller, 170 TransportController* transport_controller,
167 const std::string& content_name, 171 const std::string& content_name,
172 const std::string* bundle_transport_name,
168 bool rtcp, 173 bool rtcp,
169 const VideoOptions& options); 174 const VideoOptions& options);
170 void DestroyVideoChannel_w(VideoChannel* video_channel); 175 void DestroyVideoChannel_w(VideoChannel* video_channel);
171 DataChannel* CreateDataChannel_w(TransportController* transport_controller, 176 DataChannel* CreateDataChannel_w(TransportController* transport_controller,
172 const std::string& content_name, 177 const std::string& content_name,
178 const std::string* bundle_transport_name,
173 bool rtcp, 179 bool rtcp,
174 DataChannelType data_channel_type); 180 DataChannelType data_channel_type);
175 void DestroyDataChannel_w(DataChannel* data_channel); 181 void DestroyDataChannel_w(DataChannel* data_channel);
176 182
177 std::unique_ptr<MediaEngineInterface> media_engine_; 183 std::unique_ptr<MediaEngineInterface> media_engine_;
178 std::unique_ptr<DataEngineInterface> data_media_engine_; 184 std::unique_ptr<DataEngineInterface> data_media_engine_;
179 bool initialized_; 185 bool initialized_;
180 rtc::Thread* main_thread_; 186 rtc::Thread* main_thread_;
181 rtc::Thread* worker_thread_; 187 rtc::Thread* worker_thread_;
182 rtc::Thread* network_thread_; 188 rtc::Thread* network_thread_;
183 189
184 VoiceChannels voice_channels_; 190 VoiceChannels voice_channels_;
185 VideoChannels video_channels_; 191 VideoChannels video_channels_;
186 DataChannels data_channels_; 192 DataChannels data_channels_;
187 193
188 int audio_output_volume_; 194 int audio_output_volume_;
189 bool enable_rtx_; 195 bool enable_rtx_;
190 196
191 bool capturing_; 197 bool capturing_;
192 }; 198 };
193 199
194 } // namespace cricket 200 } // namespace cricket
195 201
196 #endif // WEBRTC_PC_CHANNELMANAGER_H_ 202 #endif // WEBRTC_PC_CHANNELMANAGER_H_
OLDNEW
« no previous file with comments | « webrtc/pc/channel_unittest.cc ('k') | webrtc/pc/channelmanager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698