Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: webrtc/examples/objc/AppRTCDemo/ARDAppClient.m

Issue 1972483002: Pass around the candidate removals events in IOS clients Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Fix a type conversion in RTCPeerConnection.mm Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/objc/AppRTCDemo/ARDAppClient.m
diff --git a/webrtc/examples/objc/AppRTCDemo/ARDAppClient.m b/webrtc/examples/objc/AppRTCDemo/ARDAppClient.m
index 86d18d1333c6b1bd58f77a366e557ff062e82010..96a40c86649b85929067c08469d9611ce2208858 100644
--- a/webrtc/examples/objc/AppRTCDemo/ARDAppClient.m
+++ b/webrtc/examples/objc/AppRTCDemo/ARDAppClient.m
@@ -330,6 +330,7 @@ static BOOL const kARDAppClientEnableTracing = NO;
[_messageQueue insertObject:message atIndex:0];
break;
case kARDSignalingMessageTypeCandidate:
+ case kARDSignalingMessageTypeCandidatesRemoval:
[_messageQueue addObject:message];
break;
case kARDSignalingMessageTypeBye:
@@ -410,6 +411,16 @@ static BOOL const kARDAppClientEnableTracing = NO;
}
- (void)peerConnection:(RTCPeerConnection *)peerConnection
+ didRemoveIceCandidates:(NSArray<RTCIceCandidate *> *)candidates {
+ dispatch_async(dispatch_get_main_queue(), ^{
+ ARDICECandidatesRemovalMessage *message =
+ [[ARDICECandidatesRemovalMessage alloc]
+ initWithRemovedCandidates:candidates];
+ [self sendSignalingMessage:message];
+ });
+}
+
+- (void)peerConnection:(RTCPeerConnection *)peerConnection
didOpenDataChannel:(RTCDataChannel *)dataChannel {
}
@@ -573,6 +584,12 @@ static BOOL const kARDAppClientEnableTracing = NO;
[_peerConnection addIceCandidate:candidateMessage.candidate];
break;
}
+ case kARDSignalingMessageTypeCandidatesRemoval: {
+ ARDICECandidatesRemovalMessage *candidateMessage =
+ (ARDICECandidatesRemovalMessage *)message;
+ [_peerConnection removeRemoteIceCandidates:candidateMessage.candidates];
+ break;
+ }
case kARDSignalingMessageTypeBye:
// Other client disconnected.
// TODO(tkchin): support waiting in room for next client. For now just

Powered by Google App Engine
This is Rietveld 408576698