Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: webrtc/base/sslidentity.h

Issue 1972383002: Make ECDSA the default certificate in WebRTC standalone (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Reordered #if Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sslidentity.h
diff --git a/webrtc/base/sslidentity.h b/webrtc/base/sslidentity.h
index 7457ff56b7c92612d6e10deb0872b5eaba91d79a..e22bfd6e52e9f15661b19debb61b09d5035afa2e 100644
--- a/webrtc/base/sslidentity.h
+++ b/webrtc/base/sslidentity.h
@@ -114,10 +114,23 @@ class SSLCertChain {
RTC_DISALLOW_COPY_AND_ASSIGN(SSLCertChain);
};
-// KT_DEFAULT is currently an alias for KT_RSA. This is likely to change.
// KT_LAST is intended for vector declarations and loops over all key types;
// it does not represent any key type in itself.
-enum KeyType { KT_RSA, KT_ECDSA, KT_LAST, KT_DEFAULT = KT_RSA };
+// KT_DEFAULT is used as the default KeyType for KeyParams.
+enum KeyType {
+ KT_RSA, KT_ECDSA, KT_LAST,
+#if defined(WEBRTC_BUILD_CHROMIUM)
+ // TODO(hbos): Because of an experiment running in Chromium which relies on
+ // RSA being the default (for performance reasons) we have this #if. ECDSA
+ // launches in Chromium by flipping a flag which overrides the default. As
+ // soon as the experiment has ended and there is no risk of RSA being the
+ // default we should make KT_DEFAULT = KT_ECDSA unconditionally.
+ // crbug.com/611698
+ KT_DEFAULT = KT_RSA
+#else
+ KT_DEFAULT = KT_ECDSA
+#endif
+};
static const int kRsaDefaultModSize = 1024;
static const int kRsaDefaultExponent = 0x10001; // = 2^16+1 = 65537
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698